[14_0_X] Fix crash in PF Clustering due to empty HCAL RecHits collection

[jsamudio]

PR description:

This fix addresses #44668 where Alpaka-based PF Clustering was crashing at HLT when HCAL is off. The reason was due to the input HCAL RecHit number being used to specify the work division for kernels, and it was not protected against a case of requesting 0 blocks when there are no RecHits.

Included now are checks on the number of rechits and the SoA size to only launch the Alpaka kernels if they are non-zero.

PR validation:

Tested HLT configuration on data which is excluding HCAL, ECAL, or Pixel, using method outlined by @mmusich in #44668 (comment)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #44693 meant for 14_0_X. Needed to address #44668 at HLT.

[cmsbuild]

A new Pull Request was created by @jsamudio for CMSSW_14_0_X.

It involves the following packages:

• RecoParticleFlow/PFClusterProducer (reconstruction)
• RecoParticleFlow/PFRecHitProducer (reconstruction)

@jfernan2, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks.
@felicepantaleo, @missirol, @sameasy, @lgray, @mmarionncern, @rovere, @seemasharmafnal, @hatakeyamak this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix crash in PF Clustering due to empty HCAL RecHits collection #44693

[cmsbuild]

cms-bot internal usage

[cmsbuild]

Pull request #44694 was updated. @cmsbuild, @mandrenguyen, @jfernan2 can you please check and sign again.

[mmusich]

backport of #44693

[mmusich]

@cmsbuild, please test

[mmusich]

type pf

[saumyaphor4252]

urgent

• Requested on behalf of HLT for data-taking operations
• To be included in 14_0_5

FYI @cms-sw/orp-l2

Saumya
(ORM)

[mmusich]

type bug-fix

[saumyaphor4252]

type bug-fix

[antoniovilela]

urgent

• Requested on behalf of HLT for data-taking operations
• To be included in 14_0_5

FYI @cms-sw/orp-l2

Saumya (ORM)

We will build a patch on top of 14_0_5 with this in.

[cmsbuild]

Pull request #44694 was updated. @jfernan2, @cmsbuild, @mandrenguyen can you please check and sign again.

[mmusich]

enable gpu

[mmusich]

test parameters:

• workflow_opts_gpu= -w upgrade
• workflows_gpu=12434.422, 12434.423,12434.424,12434.492

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e44044/38757/summary.html
COMMIT: cfe5347
CMSSW: CMSSW_14_0_X_2024-04-10-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44694/38757/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 97 lines to the logs
• Reco comparison results: 44 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3350124
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3350102
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 60 differences found in the comparisons
• DQMHistoTests: Total files compared: 6
• DQMHistoTests: Total histograms compared: 160598
• DQMHistoTests: Total failures: 2028
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 158570
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 5 files compared)
• Checked 23 log files, 30 edm output root files, 6 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+`

[mandrenguyen]

+1
Let's try that again

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1