[14.0.X] Miscellaneous fixes for dqm online clients

[mmusich]

backport of #44384

PR description:

The night of 13th March 2024, run 377827 was mistakenly acquired using the DQM DAQ key hi_run (despite having other collision keys).
This uncovered a couple of leftovers from PRs #43846 and #43257 that made few DQM online clients crash (see logs at DQM square).
These are fixed here.

PR validation:

python3 beam_dqm_sourceclient-live_cfg.py runkey=hi_run
python3 beampixel_dqm_sourceclient-live_cfg.py runkey=hi_run
python3 pixellumi_dqm_sourceclient-live_cfg.py runkey=hi_run

all compile fine now.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #44384 to CMSSW_14_0_X for 2024 data-taking purposes.

[mmusich]

type bug-fix

[cmsbuild]

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

• DQM/Integration (dqm)
• RecoVertex/PrimaryVertexProducer (reconstruction)

@antoniovagnerini, @nothingface0, @syuvivida, @tjavaid, @rvenditti, @cmsbuild, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@dgulhan, @rovere, @threus, @batinkov, @VourMa, @francescobrivio, @mmusich, @fabiocos, @mtosi, @VinInn, @GiacomoSguazzoni, @JanFSchulte, @missirol this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Miscellaneous fixes for dqm online clients #44384

[cmsbuild]

cms-bot internal usage

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd91d8/38095/summary.html
COMMIT: 4bf3772
CMSSW: CMSSW_14_0_X_2024-03-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44385/38095/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 94 lines to the logs
• Reco comparison results: 63 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3342271
• DQMHistoTests: Total failures: 1355
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3340894
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Pull request #44385 was updated. @rvenditti, @jfernan2, @mandrenguyen, @syuvivida, @nothingface0, @antoniovagnerini, @tjavaid, @cmsbuild can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd91d8/38111/summary.html
COMMIT: 51d77e4
CMSSW: CMSSW_14_0_X_2024-03-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44385/38111/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 54 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3342271
• DQMHistoTests: Total failures: 1352
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3340897
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction

[gabrielmscampos]

PR successfully tested and validated in DQM Playback machines using test set run375631_streamHIDQM.

[tjavaid]

PR successfully tested and validated in DQM Playback machines using test set run375631_streamHIDQM.

thanks @gabrielmscampos for the additional checks!

[tjavaid]

+1

• spurious differences from WF 12834.7 seen

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1