Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix globToRegex and put it in anonymous namespace #43967

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Fix globToRegex and put it in anonymous namespace #43967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions Validation/RecoTau/plugins/DQMHistNormalizer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,22 +25,23 @@

using namespace std;

// Three implementations were tested: char-by-char (this version),
// using std::string::find + std::string::replace and std::regex_replace.
// First one takes ~60 ns per iteration, second one ~85 ns,
// and the regex implementation takes nearly 1 us
std::string globToRegex(const std::string& s) {
std::string out;
out.reserve(s.size());
for (auto ch : s) {
if (ch == '*') {
out.push_back('.');
out.push_back('*');
namespace {
// Three implementations were tested: char-by-char (this version),
// using std::string::find + std::string::replace and std::regex_replace.
// First one takes ~60 ns per iteration, second one ~85 ns,
// and the regex implementation takes nearly 1 us
std::string globToRegex(const std::string& s) {
std::string out;
out.reserve(s.size());
for (auto ch : s) {
if (ch == '*') {
out.push_back('.');
}
out.push_back(ch);
}
out.push_back(ch);
return out;
}
return out;
}
} // namespace

class DQMHistNormalizer : public edm::one::EDAnalyzer<edm::one::SharedResources, edm::one::WatchRuns> {
public:
Expand Down