-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Run3 CSC conditions in 2022, 2023, 2024 realistic MC GTs and offline data GT #43900
Update Run3 CSC conditions in 2022, 2023, 2024 realistic MC GTs and offline data GT #43900
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43900/38750
|
A new Pull Request was created by @saumyaphor4252 (Saumya Phor) for master. It involves the following packages:
@consuegs, @perrotta, @cmsbuild, @saumyaphor4252 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@cmsbuild please test |
-1 Failed Tests: RelVals RelVals-INPUT AddOn
RelValsValueError: Undefined workflows: 312.0
RelVals-INPUT
AddOn Tests
Expand to see more addon errors ... |
test parameters:
|
#43900 (comment) should fix it. (Tested locally with I am unable to reproduce the issue locally with Let's test again with the updated test parameters to see if the errors still show-up. |
please test |
I rerun the two workflow with the same architecture as in the PR tests (el8_amd64_gcc12) and the error does reproduce: it happens in a few events only, and different architectures may not hit it in the 10 events tested in the wfs. So definitely there is a problem with the MC payloads. |
-1 Failed Tests: RelVals RelVals-INPUT AddOn
RelVals
RelVals-INPUT
AddOn Tests
Expand to see more addon errors ... |
It's clear from the exception messages that there is something wrong with some of the NoiseMatrix conditions data. Israr is investigating and will have to produce new payloads. (These NoiseMatrix values are used only in simulation, and not in local reco, so the real data tests were unaffected.) |
Thank you Tim, and Israr! |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43900/38818
|
Pull request #43900 was updated. @perrotta, @cmsbuild, @consuegs, @saumyaphor4252 can you please check and sign again. |
PR updated to revert the NoiseMatrix tag update in the GTs and proceed with the other 3 tags, following discussions in https://cms-talk.web.cern.ch/t/mc-gt-update-csc-conditions-for-run3-mc-gts/33583/10 |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-854324/37397/summary.html
Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR updates the Run3 CSC conditions in the following GTs:
requested in [1] and [2] respectively. More details and internal validations can be found in [3]. The tag updates are as follows:
For MC GTs:
For Run3 Offline Data GT :
the new conditions are effective from Run 347687 (2022-02-15)
[1] https://cms-talk.web.cern.ch/t/mc-gt-update-csc-conditions-for-run3-mc-gts/33583
[2] https://cms-talk.web.cern.ch/t/full-track-validation-hlt-express-prompt-offline-csc-run3-condition-updates-for-2024-data-taking/33776
[3] https://indico.cern.ch/event/1358549/#9-csc-conditions-update-for-20
GT Differences with the last ones are here:
Run3 data Offline:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_dataRun3_v1/140X_dataRun3_v3
Phase1 2022 realistic:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2022_realistic_v1/140X_mcRun3_2022_realistic_v3
Phase1 2022 realistic postEE:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2022_realistic_postEE_v1/140X_mcRun3_2022_realistic_postEE_v3
Phase1 2022 cosmics realistic:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2022cosmics_realistic_deco_v1/140X_mcRun3_2022cosmics_realistic_deco_v3
Phase1 2022 realistic hi:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2022_realistic_HI_v1/140X_mcRun3_2022_realistic_HI_v3
Phase1 2023 realistic:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2023_realistic_v1/140X_mcRun3_2023_realistic_v3
Phase1 2023 realistic postBPix:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2023_realistic_postBPix_v1/140X_mcRun3_2023_realistic_postBPix_v3
Phase1 2023 cosmics reaslistic:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2023cosmics_realistic_deco_v1/140X_mcRun3_2023cosmics_realistic_deco_v3
Phase1 2023 cosmics reaslistic postBPix:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2023cosmics_realistic_postBPix_deco_v1/140X_mcRun3_2023cosmics_realistic_postBPix_deco_v3
Phase1 2023 realistic hi:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2023_realistic_HI_v1/140X_mcRun3_2023_realistic_HI_v3
Phase1 2024 realistic:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2024_realistic_v1/140X_mcRun3_2024_realistic_v3
Phase1 2024 cosmics realistic:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2024cosmics_realistic_deco_v1/140X_mcRun3_2024cosmics_realistic_deco_v3
PR validation:
Tested successfully with
runTheMatrix.py -l 7.23,141.001,141.044,140.022,140.069,159.1,160.1,312.0,12834.0, -j 8 --ibeos
runTheMatrix.py -l 12401.0,12404.0,12412.0,12423.0,12425.0,12430.0,12431.0,12444.0,12447.0,12450.0,12504.0,12634.586,12650.0,12737.0, --what upgrade -j 8 --ibeos
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport. But backport will be followed up for 140X (considering the Full 2022+2023 ReReco campaign)