Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the GSF Track fBrem Variable Filling for Scouting Electrons: 14_0 #43880

Conversation

arsahasransu
Copy link
Contributor

PR description:

  • The fBrem variable is reconstructed at the HLT with PR43774.
  • This PR enables its accessibility to the Scouting Egamma Producer and fills the electron collection appropriately.
  • The default values in HLTScoutingEgammaProducer::fillDescriptions changed to reflect the values as expected in the path that uses the producer.
  • Backport of PR43873 in the 14_1_X release cycle.

PR validation:

  • The standards code check and formatting have been completed successfully.
  • I re-ran the recommended HLT config - /dev/CMSSW_13_3_0/GRun - with the changes in this PR on the Double Electron Gun MC and checked the variable fill. Screenshot is attached below and shows that the variable is correctly filled. The config and the output can be found in CERN AFS at the path /afs/cern.ch/work/a/asahasra/public/ScoutingStudy/For2024ScoutingEGUpdate/TestSecondRoundOfCommits/CMSSW_14_0_0_pre3/src and are named as configHLT1330V22Fbrem_ScoutingPF.py and outputHLT1330V22Fbrem_ScoutingPF.root respectively.
  • The relevant for the customisation for the menu is at the path /afs/cern.ch/work/a/asahasra/public/ScoutingStudy/For2024ScoutingEGUpdate/TestSecondRoundOfCommits/CMSSW_14_0_0_pre3/src/HLTrigger/Configuration/python/customizeHLTforScouting.py.
image

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2024

A new Pull Request was created by @arsahasransu (A.R.Sahasransu) for CMSSW_14_0_X.

It involves the following packages:

  • HLTrigger/Egamma (hlt)

@cmsbuild, @Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@silviodonato, @missirol, @Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Feb 6, 2024

backport of #43873

@mmusich
Copy link
Contributor

mmusich commented Feb 6, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Feb 6, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-848ea4/37248/summary.html
COMMIT: 2abf428
CMSSW: CMSSW_14_0_X_2024-02-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43880/37248/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor

mmusich commented Feb 6, 2024

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit df18e5b into cms-sw:CMSSW_14_0_X Feb 8, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants