-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use HCAL noise cuts from DB only for Run3 and Phase2 #43681
Conversation
cms-bot internal usage |
type pf |
type bug-fix |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43681/38361
|
A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master. It involves the following packages:
@cmsbuild, @mandrenguyen, @jfernan2, @Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9cf09d/36759/summary.html Comparison SummarySummary:
|
+hlt
|
urgent |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Follow-up of the PR #43612.
In particular, this aims to solve the issue discussed in #43612 (comment) and subsequent comments (#43612 (comment), #43612 (comment) etc).
PR validation:
136.8
and136.781
, which are crashing in current IBs with this type of error[*] ran fine after the changes in this PR.[*]
Requested conditions of type HcalPFCuts for cell (0x4538403f) (HE 16,63,3) got conditions for cell (0x0)
Requested conditions of type HcalPFCuts for cell (0x45184441) (HE 17,65,1) got conditions for cell (0x0)