Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HCAL noise cuts from DB only for Run3 and Phase2 #43681

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

swagata87
Copy link
Contributor

@swagata87 swagata87 commented Jan 9, 2024

PR description:

Follow-up of the PR #43612.
In particular, this aims to solve the issue discussed in #43612 (comment) and subsequent comments (#43612 (comment), #43612 (comment) etc).

PR validation:

136.8 and 136.781, which are crashing in current IBs with this type of error[*] ran fine after the changes in this PR.

[*]
Requested conditions of type HcalPFCuts for cell (0x4538403f) (HE 16,63,3) got conditions for cell (0x0)
Requested conditions of type HcalPFCuts for cell (0x45184441) (HE 17,65,1) got conditions for cell (0x0)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Jan 9, 2024

type pf

@mmusich
Copy link
Contributor

mmusich commented Jan 9, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43681/38361

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2024

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • RecoHI/Configuration (reconstruction)
  • RecoParticleFlow/PFProducer (reconstruction)

@cmsbuild, @mandrenguyen, @jfernan2, @Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@jazzitup, @lgray, @rovere, @mandrenguyen, @dgulhan, @seemasharmafnal, @Martin-Grunewald, @missirol, @yenjie, @MiheeJo, @yetkinyilmaz, @hatakeyamak, @SohamBhattacharya, @mmarionncern, @kurtejung, @silviodonato this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jan 9, 2024

test parameters:

  • workflows = 136.8, 136.781

@mmusich
Copy link
Contributor

mmusich commented Jan 9, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9cf09d/36759/summary.html
COMMIT: 534bb08
CMSSW: CMSSW_14_0_X_2024-01-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43681/36759/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 32 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3247277
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3247252
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 167 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Jan 10, 2024

+hlt

@mmusich
Copy link
Contributor

mmusich commented Jan 10, 2024

urgent

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f5cbbf1 into cms-sw:master Jan 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants