Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed StubAssociator to a global module #43655

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • changed from steam to global module
  • Also modernized some of the framework calls

This is part of the framework change which will require stream modules to explicitly register the use of Run/LuminosityBlock transitions.

PR validation:

Code compiles.

@Dr15Jones
Copy link
Contributor Author

@makortel FYI

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2024

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43655/38315

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

- Also modernized some of the framework calls
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43655/38317

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2024

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • SimTracker/TrackTriggerAssociation (simulation, l1)

@mdhildreth, @aloeliger, @cmsbuild, @epalencia, @civanch can you please review it and eventually sign? Thanks.
@dgulhan, @mtosi, @mmusich, @rovere, @JanFSchulte, @VinInn, @threus, @missirol, @VourMa, @GiacomoSguazzoni this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45dc00/36707/summary.html
COMMIT: a8cdf72
CMSSW: CMSSW_14_0_X_2024-01-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43655/36707/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@aloeliger
Copy link
Contributor

+l1

@civanch
Copy link
Contributor

civanch commented Jan 5, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants