-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed StubAssociator to a global module #43655
Conversation
@makortel FYI |
please test |
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43655/38315
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
- Also modernized some of the framework calls
123b2ca
to
a8cdf72
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43655/38317
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@mdhildreth, @aloeliger, @cmsbuild, @epalencia, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45dc00/36707/summary.html Comparison SummarySummary:
|
+l1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This is part of the framework change which will require stream modules to explicitly register the use of Run/LuminosityBlock transitions.
PR validation:
Code compiles.