Modernize Phase2TrackerDigiProducer

[Dr15Jones]

PR description:

• changed to a global module
• improved memory handling
• avoid unnecessary recalculations

PR validation:

Code compiles.

[Dr15Jones]

@makortel FYI

[cmsbuild]

cms-bot internal usage

[Dr15Jones]

This was found as part of our review of stream:: modules using the Run and/or LuminosityBlock transitions.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43647/38306

• This PR adds an extra 12KB to repository

[Dr15Jones]

please test

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• EventFilter/Phase2TrackerRawToDigi (reconstruction, daq)

@emeschi, @mandrenguyen, @smorovic, @jfernan2 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88e435/36693/summary.html
COMMIT: 5adaab3
CMSSW: CMSSW_14_0_X_2024-01-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43647/36693/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 98 lines from the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3247277
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247255
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction
No changes to reco comparisons

[mmusich]

No changes to reco comparisons

just for the record, that's expected because this module is not used in any reconstruction sequence, nor tested in any unit tests (AFAIU).
I am wondering what prompted the changes proposed here (not that I am against them).

[smorovic]

+daq
global module does look like a good fit.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[Dr15Jones]

I am wondering what prompted the changes proposed here (not that I am against them).

We are in the process of modifying the framework to require stream modules to explicitly request to handle Run and/or LuminosityBlock transitions. We are in the process of modifying the ~200 modules which need to be changed. As part of that change, we sometimes just move the work done in Run or LuminosityBlock calls to the Event call. This change started as one of those changes but I felt additional changes would improve things further.

[rappoccio]

+1