-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new filter type HLT2MuonPFJet to plugins for ETau Pnet HLT path #43631
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43631/38282
|
A new Pull Request was created by @brallmond (Braden Allmond) for master. It involves the following packages:
@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-346c10/36650/summary.html Comparison SummarySummary:
|
+1 If you need this in 13_3, eg, before HLT development moves to 14_0, you'd need to make a backport to 13_3. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is to add two lines which enables an existing overlap filter in the ETau DeepTau HLT path to also work in the ETau Particle Net HLT path (in development currently, targeting first menu of 2024).
PR validation:
To test this, I made a path in confDB for ETau using particle net which is located here /users/ballmond/Pnet_13_3_0_Paul_V7/CMSSW_13_3_0_GRun_plus_PaulsV7/V5 , the path name is HLT_Ele24_eta2p1_WPTight_Gsf_LoosePNetTauhTagPFJetCorrPt30_eta2p3_CrossL1_v1.
I created a config file with this path and the DeepTau counterpart and then ran the config using cmsRun on a signal file and inspected the output. I noticed events passed the DeepTau ETau path, but not the PNet path. So, I made the changes described above and shown below, after changed the corresponding filter "by hand" in the config to use the new filter type, ran the config again, and then observed events passing the path as expected.
This change passed the basic tests/formatting checks linked in the bottom of the PR template.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
I do not believe this PR needs to be backported since we are targeting the ParticleNet integration for the first HLT menu of 2024.