-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ActivityRegistry signals for EDProducer transforms #43442
Conversation
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43442/37980
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@Dr15Jones, @smuzaffar, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77755e/36182/summary.html Comparison SummarySummary:
|
If an EDProducer registers transform callbacks, the ActivityRegistry will not emit signals for - prefetching data needed for the transform - calling of any asynchronous pre-transform task - calling of the transform task The Tracer service was updated to use the new signals.
4e3c591
to
b59e852
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43442/38031
|
Pull request #43442 was updated. @makortel, @cmsbuild, @Dr15Jones, @smuzaffar can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77755e/36255/summary.html Comparison SummarySummary:
|
The usual set of spurious differences (sigh)
Plus in logs #43293 |
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
If an EDProducer registers transform callbacks, the ActivityRegistry will not emit signals for
PR validation:
Code compiles. Framework unit tests pass.