Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ActivityRegistry signals for EDProducer transforms #43442

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

Dr15Jones
Copy link
Contributor

PR description:

If an EDProducer registers transform callbacks, the ActivityRegistry will not emit signals for

  • prefetching data needed for the transform
  • calling of any asynchronous pre-transform task
  • calling of the transform task The Tracer service was updated to use the new signals.

PR validation:

Code compiles. Framework unit tests pass.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43442/37980

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • FWCore/Framework (core)
  • FWCore/Integration (core)
  • FWCore/ServiceRegistry (core)
  • FWCore/Services (core)

@Dr15Jones, @smuzaffar, @makortel can you please review it and eventually sign? Thanks.
@argiro, @rchatter, @ReyerBand, @thomreis, @fwyzard, @wang0jin, @makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77755e/36182/summary.html
COMMIT: 4e3c591
CMSSW: CMSSW_14_0_X_2023-11-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43442/36182/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

If an EDProducer registers transform callbacks, the ActivityRegistry
will not emit signals for
- prefetching data needed for the transform
- calling of any asynchronous pre-transform task
- calling of the transform task
The Tracer service was updated to use the new signals.
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43442/38031

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2023

Pull request #43442 was updated. @makortel, @cmsbuild, @Dr15Jones, @smuzaffar can you please check and sign again.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77755e/36255/summary.html
COMMIT: b59e852
CMSSW: CMSSW_14_0_X_2023-12-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43442/36255/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@makortel
Copy link
Contributor

makortel commented Dec 1, 2023

@makortel
Copy link
Contributor

makortel commented Dec 1, 2023

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants