Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal fixes to run Phase2 patatrack pixel only workflows without using phase-1 pixel conditions #42830

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 20, 2023

PR description:

Minimal fix for #42794 (comment)

PR validation:

runTheMatrix.py --what upgrade -l 24834.5,20834.501,20834.502 -t 4 -j 8 runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Sep 20, 2023

enable gpu

@mmusich
Copy link
Contributor Author

mmusich commented Sep 20, 2023

test parameters:

  • enable_tests = gpu
  • workflows_gpu = 20834.501, 20834.502
  • workflows = 24834.5
  • relvals_opt= -w upgrade

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42830/36958

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • RecoLocalTracker/SiPixelClusterizer (reconstruction)

@rappoccio, @cmsbuild, @jfernan2, @antoniovilela, @mandrenguyen, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@mtosi, @mroguljic, @fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @dkotlins, @ferencek, @gpetruc, @mmusich, @sameasy, @threus, @dgulhan, @slomeo, @tvami this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42830/36959

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #42830 was updated. @rappoccio, @cmsbuild, @jfernan2, @antoniovilela, @mandrenguyen, @fabiocos, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42830/36960

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #42830 was updated. @rappoccio, @cmsbuild, @jfernan2, @antoniovilela, @mandrenguyen, @fabiocos, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 20, 2023

ValueError: Undefined workflows: 20834.501, 20834.502

Ugh....

@mmusich
Copy link
Contributor Author

mmusich commented Sep 20, 2023

test parameters:

  • enable_tests = gpu
  • workflows_gpu = 20834.501, 20834.502
  • workflows = 24834.5
  • relvals_opts = -w upgrade,gpu,standard
  • relvals_opts_gpu = -w upgrade,gpu,standard

@mmusich
Copy link
Contributor Author

mmusich commented Sep 20, 2023

@cmsbuild, please test

@mmusich mmusich changed the title mininal fixes to run patatrack pixel only workflows without using phase-1 pixel conditions mininal fixes to run Phase2 patatrack pixel only workflows without using phase-1 pixel conditions Sep 20, 2023
@mmusich mmusich changed the title mininal fixes to run Phase2 patatrack pixel only workflows without using phase-1 pixel conditions minimal fixes to run Phase2 patatrack pixel only workflows without using phase-1 pixel conditions Sep 20, 2023
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-345fda/34840/summary.html
COMMIT: 2851674
CMSSW: CMSSW_13_3_X_2023-09-20-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42830/34840/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 23 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358044
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3358013
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 217 log files, 170 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 40118
  • DQMHistoTests: Total failures: 490
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39628
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1
This fix is fine from RECO point of view

@mmusich
Copy link
Contributor Author

mmusich commented Sep 21, 2023

@cms-sw/orp-l2 this PR should fix the remaining IB relval failures, please take a look.

@iarspider
Copy link
Contributor

@cms-sw/operations-l2 @cms-sw/orp-l2 gentle ping.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants