-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DQM/TrackingMonitorSource
cleanup
#42812
DQM/TrackingMonitorSource
cleanup
#42812
Conversation
- merged header files with implementations - implemented fillDescription methods - general clean-up of unused includes - code improvement where possible
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42812/36926
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42812/36932
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
b99bf20
to
a58cbe6
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42812/36934
|
Pull request #42812 was updated. @nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-732128/34802/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
verbose = False, | ||
trackEtaH = dict(Xbins = 60, Xmin = -3.0, Xmax = 3.0), | ||
trackPtH = dict(Xbins = 100, Xmin = 0.0 ,Xmax = 100.0), | ||
trackPhiH = dict(Xbins = 100, Xmin = 3.15, Xmax = 3.15), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbruschi
this will lead to the merging problems: the same Xmin=Xmax will mean the range is dynamic
PR description:
This is a follow-up to #41787.
Miscellaneous improvements to the
DQM/TrackingMonitorSource
package left over from the previous PR:fillDescription
methods and used the auto-generatedcfi
-s in the corresponding configuration fragments;cmssw
standard;PR validation:
Relies on the unit tests introduced in this PR:
cmssw
compilesscram b runtests
runs successfullyIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A
Cc: @dbruschi