SiStripHitEfficiencyHarvester improvements

[mmusich]

PR description:

Few miscellaneous improvements to SiStripHitEfficiencyHarvester, used int the DQM-based PCL StripHitEfficiency workflow.
Mostly moving the computation of the summary efficiency after removing the known to be inefficient, but also some internal renaming of variables.

PR validation:

Tested with

 cmsDriver.py stepHarvest -s ALCAHARVEST:SiStripHitEff --conditions 124X_dataRun3_Express_v9 --scenario pp --data --era Run3 --dasquery='file dataset=/StreamExpress/Run2022G-PromptCalibProdSiStripHitEff-Express-v1/ALCAPROMPT run=362437' -n -1 --customise_commands='process.alcasiStripHitEfficiencyHarvester.isAtPCL = cms.bool (False); process.TFileService = cms.Service("TFileService",fileName=cms.string("SiStripHitEffTest.root"))'

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

Cc: @jlagram

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42793/36905

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CalibTracker/SiStripHitEfficiency (alca)

@perrotta, @cmsbuild, @consuegs, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@echabert, @mmusich, @robervalwalsh, @gbenelli, @tocheng this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-077037/34772/summary.html
COMMIT: e1d2c16
CMSSW: CMSSW_13_3_X_2023-09-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42793/34772/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 9 lines from the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3348644
• DQMHistoTests: Total failures: 145
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3348477
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.016 KiB( 49 files compared)
• DQMHistoSizes: changed ( 1001.0 ): 0.016 KiB AlCaReco/SiStripHitEfficiency
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42793/36911

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #42793 was updated. @perrotta, @cmsbuild, @consuegs, @saumyaphor4252 can you please check and sign again.

[mmusich]

test parameters:

• workflow = 1001.2,1001.3

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-077037/34790/summary.html
COMMIT: eabca0b
CMSSW: CMSSW_13_3_X_2023-09-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42793/34790/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 3363579
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3363551
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.016 KiB( 51 files compared)
• DQMHistoSizes: changed ( 1001.0 ): 0.016 KiB AlCaReco/SiStripHitEfficiency
• Checked 225 log files, 169 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[perrotta]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1