RobustParticleTransformer in DataFormats/BTauReco

[AnnikaStein]

PR description:

A new jet flavour tagging algorithm (RobustParTAK4) is to be integrated soon, and relevant DataFormats need to be modified to handle more input variables (e.g. more features for charged / neutral candidates, as well as for secondary vertices). While we have a first full integration in our private recipes, we aim to integrate the respective producers and the inference part at a later time to implement improvements to the timing of the new modules with dynamic input sizes, which is a work-in-progress. This PR is for the data structure only, to meet the POG updates deadline.

Some relevant links to meetings where these developments have been discussed in BTV: https://indico.cern.ch/event/1218499/#5-adversarial-training-for-par and https://indico.cern.ch/event/1218501/#4-adversarial-training-for-par
And a short summary of the activities and milestones related to this project was part of the roundtable (https://indico.cern.ch/event/1236178/#4-general-status-and-feedback)

PR validation:

Basic set of code checks / code-format only (more dedicated tests will be added as part of the full integration, of which one can view a preview here: master...AnnikaStein:cmssw:from-CMSSW_13_0_0_pre3 where we tested the new inputs and outputs for the AOD to MiniAOD step, followed by mini to nano). More tests to follow in a not as time critical follow-up PR related to validation of inputs and outputs, which are however independent of the minimal changes introduced in this PR. With the present PR, we only create the necessary data structure (and will therefore not have to patch these in later, in line with https://twiki.cern.ch/twiki/bin/viewauth/CMS/ReleaseSchedule#Notes_on_Patch_Releases_formalis).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40706/34076

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40706/34076/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40706/34076/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40706/34079

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @AnnikaStein (Annika Stein) for master.

It involves the following packages:

• DataFormats/BTauReco (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @JyothsnaKomaragiri, @AnnikaStein, @rovere, @missirol, @andrzejnovak, @demuller this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[AnnikaStein]

@perrotta
I received a last minute change request - three features per candidate for the 4-vectors. Sorry for that.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40706/34096

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #40706 was updated. @mandrenguyen, @clacaputo can you please check and sign again.

[perrotta]

@perrotta I received a last minute change request - three features per candidate for the 4-vectors. Sorry for that.

@AnnikaStein is your update complete by now?
Since, by chances, our entries in this thread almost overlapped, I think my "please build" actually already picked your last commit. Just to be sure. better to restart them nonetheless

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40706/34109

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #40706 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e176b/30475/summary.html
COMMIT: 6cd9a6c
CMSSW: CMSSW_13_0_X_2023-02-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40706/30475/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 13 lines from the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555852
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555827
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction
resign

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1