[RECO] [CLANG] More fixes on unused-but-set-variable warnings

[aandvalenzuela]

Follow-up PR for #40397.
This PR fixes unused-but-set-variable warnings which we get with LLVM14 in CLANG IBS

[aandvalenzuela]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40520/33720

• This PR adds an extra 60KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CommonTools/Utils/test/testExpressionParser.cc modified in PR(s): [RECONSTRUCTION] [CLANG] Fixes warnings reported by clang 14 #40516

[cmsbuild]

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for master.

It involves the following packages:

• CommonTools/Utils (reconstruction)
• RecoParticleFlow/PFProducer (reconstruction)
• RecoPixelVertexing/PixelVertexFinding (reconstruction)
• RecoTracker/MkFitCore (reconstruction)
• TrackingTools/TrackRefitter (reconstruction)

@mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @abbiendi, @CeliaFernandez, @mmusich, @cericeci, @mmarionncern, @makortel, @andrea21z, @JanFSchulte, @jhgoh, @lgray, @missirol, @HuguesBrun, @seemasharmafnal, @trocino, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @hatakeyamak, @ebrondol, @mtosi, @dgulhan, @Fedespring, @lecriste, @gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[clacaputo]

@cmsbuild please test

[aandvalenzuela]

please test

• [RECONSTRUCTION] [CLANG] Fixes warnings reported by clang 14 #40516 already handles warning in CommonTools/Utils/test/testExpressionParser.cc

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40520/33729

• This PR adds an extra 56KB to repository

[cmsbuild]

Pull request #40520 was updated. @mandrenguyen, @clacaputo can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5740c6/29989/summary.html
COMMIT: dcffbc1
CMSSW: CMSSW_13_0_X_2023-01-13-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40520/29989/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.15 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555538
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555513
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

Hello, can you please delete instead of commenting out lines in TrackTransformerForCosmicMuons.cc ?

[aandvalenzuela]

Hello @mandrenguyen,
Sure, I can do that. I have commented these lines because there is some comented code in https://github.com/cms-sw/cmssw/blob/master/TrackingTools/TrackRefitter/src/TrackTransformerForCosmicMuons.cc#L540 that also uses the dz variable. So in case someone uncomments these lines, there won't be trace of this variable. Should I also remove the already commented code?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40520/33808

• This PR adds an extra 56KB to repository

[cmsbuild]

Pull request #40520 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.

[aandvalenzuela]

please test

• @mandrenguyen, let me know if you also want me to remove the already commented out lines that contain those variables or if it is fine to leave it like that. Thanks!

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5740c6/30078/summary.html
COMMIT: 233472b
CMSSW: CMSSW_13_0_X_2023-01-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40520/30078/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555479
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555451
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction
technical, no change to reco

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1