Add missing include to TransformerBase.cc

[makortel]

PR description:

#39557 broke GCC 11 IBs because of a missing include of optional added here.

PR validation:

None (edited in the web)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39753/32609

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

• FWCore/Framework (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@missirol, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[smuzaffar]

please test for el8_amd64_gcc11

[smuzaffar]

although GCC 11 tests will fail as IB is broken by PR build shows that compilation worked https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70fff4/28324/build-logs/

[cmsbuild]

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70fff4/28324/summary.html
COMMIT: 0e05c66
CMSSW: CMSSW_12_6_X_2022-10-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39753/28324/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestFWCoreFrameworkESRefer had ERRORS
---> test TestFWCoreFrameworkDeleteEarly had ERRORS
---> test TestFWCoreFrameworkESProducerLooper had ERRORS
---> test TestFWCoreFrameworkEarlyTerminationSignal had ERRORS
and more ...

RelVals

• 4.534.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log
• 4.224.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log
• 5.15.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

Expand to see more relval errors ...

• 7.3
• 8.0
• 9.0
• 25.0
• 135.4
• 136.731
• 136.7611
• 136.793
• 136.8311
• 138.4
• 136.88811
• 136.874
• 138.5
• 139.001
• 140.53
• 140.56
• 158.01
• 1306.0
• 1330.0
• 2018.1
• 101.0
• 312.0
• 25202.0
• 1000.0
• 1001.0
• 10024.0
• 10042.0
• 10224.0
• 10824.0
• 11634.0
• 11634.7
• 11634.911
• 11634.914
• 11834.0
• 12434.0
• 13234.0
• 13434.0
• 20834.0
• 20834.75
• 20896.0
• 20900.0
• 21034.999
• 23234.0
• 250202.181
• 2500.601

AddOn Tests

• read312RV

----- Begin Fatal Exception 18-Oct-2022 09:26:27 CEST-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'CondorStatusService' in category 'CMS EDM Framework Service'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

• fastsimcmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Tue Oct 18 09:26:28 2022-date Tue Oct 18 09:26:27 2022 s - exit: 256
• fastsim1cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Tue Oct 18 09:26:29 2022-date Tue Oct 18 09:26:28 2022 s - exit: 256

Expand to see more addon errors ...

• fastsim2
• pat1
• hlt_mc_Fake
• hlt_mc_Fake
• hlt_mc_Fake
• hlt_mc_Fake1
• hlt_mc_Fake1
• hlt_mc_Fake1
• hlt_mc_Fake2
• hlt_mc_Fake2
• hlt_mc_Fake2
• hlt_mc_GRun
• hlt_mc_GRun
• hlt_mc_GRun
• hlt_mc_HIon
• hlt_mc_HIon
• hlt_mc_HIon
• hlt_mc_PIon
• hlt_mc_PIon
• hlt_mc_PIon
• hlt_mc_PRef
• hlt_mc_PRef
• hlt_mc_PRef
• hlt_data_Fake
• hlt_mc_Fake
• hlt_data_Fake
• hlt_data_Fake1
• hlt_mc_Fake1
• hlt_data_Fake1
• hlt_data_Fake2
• hlt_mc_Fake2
• hlt_data_Fake2
• hlt_data_GRun
• hlt_mc_GRun
• hlt_data_GRun
• hlt_data_HIon
• hlt_mc_HIon
• hlt_data_HIon
• hlt_data_PIon
• hlt_mc_PIon
• hlt_data_PIon
• hlt_data_PRef
• hlt_mc_PRef
• hlt_data_PRef

[makortel]

+1

gcc11 compiling should be sufficient

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

merge

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70fff4/28323/summary.html
COMMIT: 0e05c66
CMSSW: CMSSW_12_6_X_2022-10-17-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39753/28323/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-70fff4/2500.601_mc126X+TTBarMINIAOD12.6+NANO_mc12.6+HRV_NANO_mc

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3391158
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3391130
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found