Add PFDiJetCorrCheckerWithDiTau producer for DoubleTau+VBF-jets HLT paths

[mbluj]

PR description:

This PR adds a new HLT producer of PFJets forming pairs with high mass and not overlapping with pairs of PFTaus passing an HLT filter. The producer will be used in DoubleTau+VBF-jets trigger paths as replacement of the currently used PFJet-PFTau overlap filter. It is estimated that the new producer will allow to increase efficiency of the trigger by ~10% for the same rate compared to triggers with currently used overlap filter.

PR validation:

Tested with dedicated configuration containing HLT paths using the new module.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37116/28622

• This PR adds an extra 16KB to repository

• Found files with invalid states:

  • RecoTauTag/HLTProducers/interface/PFJetsTauCorrelationCondition.h:
    • Added: 1d49aae
    • Deleted: 9f77e8a
  • RecoTauTag/HLTProducers/src/PFJetsTauCorrelationCondition.cc:
    • Added: 1d49aae
    • Deleted: 9f77e8a

[cmsbuild]

A new Pull Request was created by @mbluj for master.

It involves the following packages:

• RecoTauTag/HLTProducers (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@silviodonato, @mbluj, @azotz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37116/28633

• This PR adds an extra 12KB to repository

• Found files with invalid states:

  • RecoTauTag/HLTProducers/src/PFDiJetCorrCheckerWithDiTau.cc:
    • Added: 9f77e8a
    • Modified: 3ca65f8
    • Deleted: 1c53a78
  • RecoTauTag/HLTProducers/interface/PFJetsTauCorrelationCondition.h:
    • Added: 1d49aae
    • Deleted: 9f77e8a
  • RecoTauTag/HLTProducers/interface/PFDiJetCorrCheckerWithDiTau.h:
    • Added: 9f77e8a
    • Modified: 3ca65f8
    • Deleted: 1c53a78
  • RecoTauTag/HLTProducers/src/PFJetsTauCorrelationCondition.cc:
    • Added: 1d49aae
    • Deleted: 9f77e8a

[cmsbuild]

Pull request #37116 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

[mbluj]

Review comments were addressed, namely:

• header and implementation files were merged,
• name of module begins now from "HLT",
• output collection is sorted in pt

[Martin-Grunewald]

please test

[missirol]

Here's the review, just a few technical suggestions.

It would be useful to know if this PR needs to be integrated by Mar-8 (pre6); i think it's feasible, but just to know.

[mbluj]

Here's the review, just a few technical suggestions.

It would be useful to know if this PR needs to be integrated by Mar-8 (pre6); i think it's feasible, but just to know.

I think it will be great to have it for pre6 to boost integration the module within actual HLT paths, but I am checking details with proponents.

[mbluj]

@missirol requested changes were implemented and committed.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37116/28643

• This PR adds an extra 20KB to repository

• Found files with invalid states:

  • RecoTauTag/HLTProducers/src/PFDiJetCorrCheckerWithDiTau.cc:
    • Added: 9f77e8a
    • Modified: 3ca65f8
    • Deleted: 1c53a78
  • RecoTauTag/HLTProducers/interface/PFJetsTauCorrelationCondition.h:
    • Added: 1d49aae
    • Deleted: 9f77e8a
  • RecoTauTag/HLTProducers/interface/PFDiJetCorrCheckerWithDiTau.h:
    • Added: 9f77e8a
    • Modified: 3ca65f8
    • Deleted: 1c53a78
  • RecoTauTag/HLTProducers/src/PFJetsTauCorrelationCondition.cc:
    • Added: 1d49aae
    • Deleted: 9f77e8a

[cmsbuild]

Pull request #37116 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21df65/22783/summary.html
COMMIT: de1243a
CMSSW: CMSSW_12_3_X_2022-03-02-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37116/22783/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3990927
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3990891
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

• adds a new producer for HLT, not presently used in any central wf nor HLT menu

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1