Bug fix: TrackerTopologyEP added and Warning log file added: backport from 71x

[venturia]

This pull request is a back port of #3400

[cmsbuild]

A new Pull Request was created by @venturia for CMSSW_7_0_X.

Bug fix: TrackerTopologyEP added and Warning log file added: backport from 71x

It involves the following packages:

DQM/SiStripMonitorSummary

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3401/133/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3401/133/summary.html

[danduggan]

It looks like this PR is failing DQM test 9 (linked from the summary), with a seg fault showing up at postprocessing. Could you check this?

[venturia]

Hi,

I know it is a sort of sloppy answer of mine, but it is possible that the seg fault is NOT due to my pull request and it is due to a different problem? My changes are expected to affect only cfg files in the test directory. Otherwise I can help but I need clear instructions on how to reproduce the problem.

On Apr 24, 2014, at 9:36 , danduggan <[email protected]mailto:[email protected]>
wrote:

It looks like this PR is failing DQM test #9#9 (linked from the summary), with a seg fault showing up at postprocessing. Could you check this?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3401#issuecomment-41251674.

[rovere]

@danduggan @venturia @deguio I confirm the offending library seem to be pluginValidationRecoEgammaPlugins.so, nothing related to Andrea's PR.

Is it possible that this test is failing since a while, and went unnoticed .. ?

Ciao,
M.

[danduggan]

Thanks Marco for the clarification. My guess is that it must have been failing for some time, and wasn't noticed because of the infrequency of backports. Something for me to follow up on.

[danduggan]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[deguio]

hello,
this is known and understood in 70X. it wasn't unnoticed. the DQM tests were broken at a certain point and I didn't submit the fix for 70X, but only for 71X.
sorry if this created confusion.

ciao,
F.

(the problem is with the tests which search for the wrong file and not with the PhotonPostProcessor which, by the way, is not protected against missing histos)