Implementing dedicated LHE filter for removing events with mttbar below a certain threshold

[gsorrentino18]

PR description:

This PR implements a new filter, requested by GEN conveners, which removes events with invariant TTbar mass below a given threshold at LHE level.
An additional cut on the quarks pT is also applied, and both mass and pT thresholds can be customized in the _cfi file.

PR validation:

The filter has been tested locally in the CMSSW_12_0_X_2021-04-27-1100 release.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33541/22321

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @gsorrentino18 (Giulia Sorrentino) for master.

It involves the following packages:

GeneratorInterface/GenFilters

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[agrohsje]

Hi @gsorrentino18 . Thanks so much for this PR. As we often have say 600 to 1000 and above 1000 or so, you might add min/max? You should also call the file Filter instead of filter to be consistent. When you check pdgid(top)+pdgid(antitop)=0 you could add an else if this is not the case and throw a message as you do before.
What do you think?

[gsorrentino18]

Hi @gsorrentino18 . Thanks so much for this PR. As we often have say 600 to 1000 and above 1000 or so, you might add min/max? You should also call the file Filter instead of filter to be consistent. When you check pdgid(top)+pdgid(antitop)=0 you could add an else if this is not the case and throw a message as you do before.
What do you think?

Hi Alexander, thanks for your comments.
About the min/max you mentioned, if I understand well, what are you asking is adding also a maximum threshold for tt invariant mass?
If so, I could do it in two different ways:

1. Adding a max value and setting it to an arbitrary large number (like 999999) when the filter is used for selecting only ttbar events over a minimum threshold.
2. Adding a flag in order to specify if the ttbar mass will have to lie in a given mass window or only above a minimum threshold. This just to avoid putting the arbitrary number as max in the config file.
   Let me know what do you prefer.

[agrohsje]

Hi @gsorrentino18 , I have no strong preference. I would probably always use -1 as default and if
mttmax > -1 and mtt > mttmax veto
mttmin > -1 and mtt < mttmin veto .

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33541/22392

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33541/22392/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33541/22392/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33541/22393

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #33541 was updated. @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

[agrohsje]

Thanks Giulia. Can you remove the old file from this PR and still add -1 as initial values from min and max ?

[cmsbuild]

Pull request #33541 was updated. @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

[agrohsje]

Hi @gsorrentino18. Sorry, misunderstanding. My point was that min and max are not initialized in c++.
What you had in the python was ok.

[gsorrentino18]

Hi @gsorrentino18. Sorry, misunderstanding. My point was that min and max are not initialized in c++.
What you had in the python was ok.

Ok. I'll go back to the previous python values and initialize min, max and pTmin as well. Thanks

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33541/22396

• This PR adds an extra 16KB to repository

• Found files with invalid states:

  • GeneratorInterface/GenFilters/plugins/LHEmttfilter.cc:
    • Added: ef0603a
    • Deleted: 58a58d3

[cmsbuild]

Pull request #33541 was updated. @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

[agrohsje]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9d17d/14743/summary.html
COMMIT: 3341c97
CMSSW: CMSSW_12_0_X_2021-04-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33541/14743/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2662646
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2662617
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[agrohsje]

+generators

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1