Phase2 he29

[bsunanda]

Necessary to have these changes to complement the changes in bsunanda:Phase2-HE28 and also a tag kpedro88:Phase2-HE29

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_6_2_X_SLHC.

Phase2 he29

It involves the following packages:

DQM/HcalMonitorTasks
SimCalorimetry/CastorSim
SimCalorimetry/HcalSimAlgos

@civanch, @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @mdhildreth, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mark-grimes]

merge

Along with #3287 fixes at least test 10000 (all test were previously broken). Full testing in progress.

[mark-grimes]

Actually, I spoke too soon. All the tests are fixed except 10000 (ping @kpedro88 so he sees this).

Tests 10200, 10400, 11200, 11400, 12000, 12800, 13000, 13600 and 14600 pass all steps.
Tests 12200, 12400, 12600, 13800, 14000, 14200 and 14400 fail in step 2 with known errors.
Test 10000 crashes in step 3 with

#5  0x00002b1b0e4edbef in HcalTopology::etaRange(HcalSubdetector, int) const () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-04-13-0200/lib/slc5_amd64_gcc472/libGeometryCaloTopology.so
#6  0x00002b1b136ccc1e in HcalHF_PETalgorithm::HFSetFlagFromPET(HFRecHit&, edm::SortedCollection<HFRecHit, edm::StrictWeakOrdering<HFRecHit> >&, HcalChannelQuality const*, HcalSeverityLevelComputer const*) () from /tmp/grimes/CMSSW_6_2_X_SLHC_2014-04-14-0200/lib/slc5_amd64_gcc472/libRecoLocalCaloHcalRecAlgos.so
#7  0x00002b1b1eea124c in HcalHitReconstructor::produce(edm::Event&, edm::EventSetup const&) () from /tmp/grimes/CMSSW_6_2_X_SLHC_2014-04-14-0200/lib/slc5_amd64_gcc472/pluginRecoLocalCaloHcalRecProducers.so
#8  0x00002b1afcf17ee0 in edm::EDProducer::doEvent(edm::EventPrincipal&, edm::EventSetup const&, edm::CurrentProcessingContext const*) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-04-13-0200/lib/slc5_amd64_gcc472/libFWCoreFramework.so

This is with CMSSW_6_2_X_SLHC_2014-04-14-0200, #3287 and #3296. I had to recompile a load of packages because of build failures in the IB (because it has #3278 but not #3287 or #3296). This should all be in tomorrow's IB though.

[kpedro88]

That was my fault. In my commit #3287, I should have used abs(ieta) instead of ieta in the argument to etaRange(). I'll submit a pull request which fixes this problem.