Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CondTools/SiPixel: apply necessary changes to work with python3 #32060

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 9, 2020

PR description:

Fixed unit tests in CondTools/SiPixel, addressing #31796 (comment)
As done previously in #31166

  • converted to print function
  • use next function
  • use io.open

PR validation:

The unit tests were run under a python 2 and a python 3 RelVal.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport needed.
cc: @tvami

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32060/19655

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondTools/SiPixel

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@ferencek, @mmusich, @dkotlins, @VinInn, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 9, 2020

@cmsbuild please test for CMSSW_11_2_PY3_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

The tests are being triggered in jenkins.
Test Parameters:

@mmusich
Copy link
Contributor Author

mmusich commented Nov 9, 2020

@mrodozov FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

+1
Tested at: 5bb78d8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe53ac/10582/summary.html
CMSSW: CMSSW_11_2_PY3_X_2020-11-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe53ac/10582/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4114 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2530616
  • DQMHistoTests: Total failures: 731
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2529884
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 148 log files, 22 edm output root files, 35 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Nov 10, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

please test
for the standard release (py2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 10, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 5bb78d8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe53ac/10622/summary.html
CMSSW: CMSSW_11_2_X_2020-11-10-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe53ac/10622/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529296
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529273
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 22 edm output root files, 35 DQM output files

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 091e973 into cms-sw:master Nov 10, 2020
@mmusich mmusich deleted the python3CondToolsSiPixel_v2 branch November 11, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants