-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CondTools/SiPixel: apply necessary changes to work with python3 #32060
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32060/19655
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CondTools/SiPixel @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test for CMSSW_11_2_PY3_X |
The tests are being triggered in jenkins.
|
@mrodozov FYI |
+1 |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
PR description:
Fixed unit tests in
CondTools/SiPixel
, addressing #31796 (comment)As done previously in #31166
print
functionnext
functionio.open
PR validation:
The unit tests were run under a python 2 and a python 3 RelVal.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, no backport needed.
cc: @tvami