-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Phase 2 Trackers T21 + T22 + T23 (Mechanical Update in Outer Tracker + Sensors studies in Inner Tracker) #30927
Conversation
…mmusich with cms-merge-topic
…acilitate IT insertion) + In all TEDD, update dee sensors inter-spacing in Z. Add T22 Inner Tracker topology file.
…dd D64 (Tracker T23).
…hen I added 3D sensors support, so update README now ;p.
Pull request #30927 was updated. @andrius-k, @gouskos, @lveldere, @chayanit, @wajidalikhan, @sbein, @schneiml, @ianna, @kpedro88, @rekovic, @fioriNTU, @tlampen, @jpata, @pohsun, @santocch, @peruzzim, @perrotta, @civanch, @makortel, @cmsbuild, @fwyzard, @davidlange6, @smuzaffar, @Dr15Jones, @cvuosalo, @ssekmen, @mdhildreth, @jfernan2, @tocheng, @slava77, @ggovi, @qliphy, @fabiocos, @benkrikler, @kmaeshima, @christopheralanwest, @pgunnell, @alja, @franzoni, @silviodonato, @fgolf, @mariadalfonso can you please check and sign again. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30927/17420
|
Pull request #30927 was updated. @andrius-k, @gouskos, @lveldere, @chayanit, @wajidalikhan, @sbein, @schneiml, @ianna, @kpedro88, @rekovic, @fioriNTU, @tlampen, @jpata, @pohsun, @santocch, @peruzzim, @perrotta, @civanch, @makortel, @cmsbuild, @fwyzard, @davidlange6, @smuzaffar, @Dr15Jones, @cvuosalo, @ssekmen, @mdhildreth, @jfernan2, @tocheng, @slava77, @ggovi, @qliphy, @fabiocos, @benkrikler, @kmaeshima, @christopheralanwest, @pgunnell, @alja, @franzoni, @silviodonato, @fgolf, @mariadalfonso can you please check and sign again. |
Reopened it at #30976 . |
+1 |
The tests are being triggered in jenkins.
|
please close |
@smuzaffar @mrodozov can we prevent the bot from starting tests for closed PRs? |
sure, bot should not test closed PR. I will fix it. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
move to #31673 |
PR description:
This PR:
T21:
tkLayout description: http://ghugo.web.cern.ch/ghugo/layouts/T21/OT800_IT615/layoutpixel.html
Geometry scenario: 2026D63.
Workflows: 294xx (no PU), 296xx (PU).
T22:
tkLayout description: http://ghugo.web.cern.ch/ghugo/layouts/T22/OT800_IT621/layoutpixel.html
Geometry scenario: 2026D64.
Workflows: 298xx (no PU), 300xx (PU).
T23:
tkLayout description: http://ghugo.web.cern.ch/ghugo/layouts/T23/OT800_IT700/layoutpixel.html
Geometry scenario: 2026D65.
Workflows: 302xx (no PU), 304xx (PU).
Following comparisons should be made:
Validate new Outer Tracker:
Compare T21 versus T20 (2026D63 versus 2026D56).
Should not expect any meaningful change in the tracking performance (maybe an extremely tiny degradation).
Inner Tracker sensors studies:
Now have a common base to compare different sensors options.
Only bricked pixels sensors option is missing (I included that geometry in another private branch).
25x100 -> 50x50:
Compare T22 (50x50, planar) versus T21 (25x100, planar) (2026D64 versus 2026D63).
An interesting fast sim estimate is available at:
25x100: http://ghugo.web.cern.ch/ghugo/layouts/T21/OT800_IT615/errorstracker.html
50x50: http://ghugo.web.cern.ch/ghugo/layouts/T22/OT800_IT621/errorstracker.html
With obviously, especially visible here at high pT, a significant degradation of pT and transverse impact parameter resolution, and an improvement of longitudinal impact parameter resolution. Of course less visible at low pT (multiple scattering).
planar -> 3D:
Compare T23 (3D) versus T21 (planar) (2026D65 versus 2026D63).
tkLayout track parameters code fully debugged and operational in the case of 3D sensors.
Though, would need to fix 3D local resolution parametrization used as input in tkLayout, to get meaningful fast sim results on that front as well.
PR validation:
Following was done for CMSSW validation:
FYI: @dpiparo @VinInn @cvuosalo @civanch @ianna @emiglior @skinnari @mmusich @jalimena @fabiocos @kpedro88