-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix stacked efficiency plots #30453
fix stacked efficiency plots #30453
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30453/16586
|
A new Pull Request was created by @mtosi (mia tosi) for master. It involves the following packages: Validation/RecoTrack @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
as reported in the conversation of #28622
since 11_1_0_pre3 the efficiency plot in the DQM have the TH1::kIsAvarage bit set,
which prevents the efficiency histograms to be used in the proper way by the THStack
(by adding the different histograms the results is not the sum, but their average)
this PR fixes the handling of these plots in the TRK POG script
if this PR is a backport please specify the original PR and why you need to backport that PR:
I'm going to make the backport to 111X for making the proper plots for the HLT TDR (for completeness and avoiding patch/private code)