Updates in DT segments reco; bugfix in DT timing in MuonIdentification #1690

namapane · 2013-12-05T20:16:29Z

-Bugfix in DT timing in RecoMuon/MuonIdentification

-Rearranged DT segment building code + updates to DT MT pattern reco.
(regression-tested: http://cmsdoc.cern.ch/~ptraczyk/plots_700.pdf)

-Validation/DTRecHits: moved histogram booking to BeginRun, as requested (#1004 (comment))

updates to validation histograms and tools for plotting.

…ix in DT timing in RecoMuon/MuonIdentification

cmsbuild · 2013-12-05T20:18:03Z

A new Pull Request was created by @namapane (Nicola Amapane) for CMSSW_7_0_X.

Updates in DT segments reco; bugfix in DT timing in MuonIdentification

It involves the following packages:

RecoMuon/TrackingTools
Validation/DTRecHits
RecoLocalMuon/DTSegment
RecoMuon/MuonIdentification

@nclopezo, @danduggan, @rovere, @cmsbuild, @thspeer, @deguio, @slava77, @eliasron can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

slava77 · 2013-12-12T10:33:18Z

@slava77 working on it

slava77 · 2013-12-12T10:55:25Z

Validation/DTRecHits/test/writeSummaryTable.r

@@ -0,0 +1,261 @@
+//------------------------------


Why this file extension? .r?

It's a root script. It's just used for some manual plotting.

Nicola

On 12-Dec-13 11:55, slava77 wrote:

In Validation/DTRecHits/test/writeSummaryTable.r:

@@ -0,0 +1,261 @@
+//------------------------------

Why this file extension? .r?

—
Reply to this email directly or view it on GitHub
https://github.com/cms-sw/cmssw/pull/1690/files#r8296405.

slava77 · 2013-12-12T12:38:01Z

@ktf @nclopezo
Giulio and David,
Do I need to send a separate message to get basic jenkins tests?
This PR is a few days old.

slava77 · 2013-12-12T12:40:06Z

-1

I tried in CMSSW_7_0_X_2013-12-05-0200 (sign279)

An exception of category 'Configuration' occurred while
[0] Constructing the EventProcessor
[1] Constructing module: class=DTRecSegment4DProducer label='dt4DCosmicSegments'
Exception Message:
MissingParameter: Parameter 'enable_3par_fit' not found.

@namapane
Nicola, Please take a look.
It looks like some commits may be missing.

ktf · 2013-12-12T12:41:14Z

@slava77 the tests are started by hand. @nclopezo did you overlook this one or there is some specific problem?

nclopezo · 2013-12-12T12:44:09Z

Hi,

I just queued the tests, I must have overlooked this one, sorry.

slava77 · 2013-12-12T15:34:40Z

just to remind the instructions,
https://twiki.cern.ch/twiki/bin/viewauth/CMS/RecoIntegration#Runtime_Check_FS_and_HLT

runTheMatrix.py -s --useInput all
should complete before we can proceed

Cheers

Slava

Dr15Jones · 2013-12-16T17:08:34Z

RecoLocalMuon/DTSegment/src/DTMeantimerPatternReco.cc

+  if ((chi2/(assHits.size()-3)<theMaxChi2)) return seg;
+    else {
+      delete seg;
+      return false;


return nullptr;

namapane · 2013-12-16T17:12:30Z

Let me add @ptraczyk to the thread, since he is the developer.

Some comments:

The error reported by @nclopezo is the same already reported by @slava77 : one new parameter needs to be added to the cfg of the cosmic reco as well.
@deguio: this std::bad_alloc looks a bit strange, can you provide more detaisl on how to reproduce this?
@ptraczyk, can you implement the changes suggested by @Dr15Jones ?

Thanks
Nicola

Dr15Jones · 2013-12-16T17:16:54Z

RecoLocalMuon/DTSegment/src/DTMeantimerPatternReco.cc

-
-  // If no more iterations - store the current segment
+  DTSegmentCand* seg = fitWithT0(sl,assHits, chi2l, t0_corrl,debug);
+  if (!seg->good()) {


This will lead to a seg-fault if seg==0 which is one of the values the call can return.

into DTSegmentFitUpdate7X

cmsbuild · 2013-12-17T17:48:06Z

Pull request #1690 was updated. @nclopezo, @danduggan, @rovere, @cmsbuild, @anton-a, @thspeer, @deguio, @slava77, @eliasron can you please check and sign again.

deguio · 2013-12-17T18:17:34Z

ciao @namapane
I am testing the pull request, but I get a segFault.

I guess that the interesting frame of the bt is:
#5 0x00002b46b9dd1f5c in MuonSegmentMatcher::matchDT(reco::Track const&, edm::Event const&) () from /build/deguio/releaseIntegration/70X/17122013/CMSSW_7_0_X_2013-12-16-0200_1690/lib/slc5_amd64_gcc481/libRecoMuonTrackingTools.so

if you want to have a look at the full bt, you can login on vocms123:/build/deguio/releaseIntegration/70X/17122013/CMSSW_7_0_X_2013-12-16-0200_1690/src/DQMServices/Components/test

slava77 · 2013-12-17T18:53:38Z

-1

Tested in CMSSW_7_0_X_2013-12-16-0200
All HLT steps failed
[1] Constructing module: class=DTRecSegment4DProducer label='hltDt4DSegments'
Exception Message:
MissingParameter: Parameter 'enable_3par_fit' not found.

The wflows without HLT failed in reco step

%MSG-e FatalSystemSignal: MuonIdProducer:muonsFromCosmics 17-Dec-2013 19:40:22 CET Run: 177790 Event: 280479856
A fatal system signal has occurred: segmentation violation
%MSG

I guess I should've waited for a clear message that this is now good to go.

namapane · 2013-12-17T20:01:38Z

@ptraczyk may want to comment, but I think the commit should include the changes suggested by @Dr15Jones.

Before testing it further we also need the new parameter to be included in the HLT config in confDB.
(The notification of the update of the branch is automatic, I think, it was not a request to retest it right away)

Piotr, can you check the segfault in cosmic reco in the path without HLT in the meanwhile?

Cheers,
Nicola

slava77 · 2013-12-17T20:11:36Z

On 12/17/13, 9:01 PM, Nicola Amapane wrote:

@ptraczyk https://github.com/ptraczyk may want to comment, but I think
the commit should include the changes suggested by @Dr15Jones
https://github.com/Dr15Jones.

Before testing it further we also need the new parameter to be included
in the HLT config in confDB.
(The notification of the update of the branch is automatic, I think, it
was not a request to retest it right away)

Piotr, can you check the segfault in cosmic reco in the path without HLT
in the meanwhile?

OK, no problems.
I'll wait for a clear "go ahead, it's ready" next time.

Cheers

    --slava

Cheers,
Nicola

—
Reply to this email directly or view it on GitHub
#1690 (comment).

Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: [email protected]
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)

deguio · 2013-12-17T22:36:28Z

-1

ptraczyk · 2013-12-18T08:40:40Z

yes, sorry for the confusion, this wasn't the wersion that's supposed to be
working yet - as @namapane said I added in the changes from @Dr15Jones, but
the HLT is not fixed yet. I will investigate the segfault in cosmics, this
shoudln't be happening.

best,
Piotr

2013/12/17 slava77 [email protected]

On 12/17/13, 9:01 PM, Nicola Amapane wrote:

@ptraczyk https://github.com/ptraczyk may want to comment, but I think

the commit should include the changes suggested by @Dr15Jones
https://github.com/Dr15Jones.

Before testing it further we also need the new parameter to be included
in the HLT config in confDB.
(The notification of the update of the branch is automatic, I think, it
was not a request to retest it right away)

Piotr, can you check the segfault in cosmic reco in the path without HLT
in the meanwhile?

OK, no problems.
I'll wait for a clear "go ahead, it's ready" next time.

Cheers

--slava

Cheers,
Nicola

—
Reply to this email directly or view it on GitHub
#1690 (comment).

Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: [email protected]
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1690#issuecomment-30786250
.

cmsbuild · 2013-12-19T12:58:06Z

Pull request #1690 was updated. @nclopezo, @danduggan, @rovere, @cmsbuild, @anton-a, @thspeer, @deguio, @slava77, @eliasron can you please check and sign again.

ptraczyk · 2013-12-19T13:22:42Z

FYI this commit now contains all the modifications, it passes the tests on
my side.

2013/12/19 cmsbuild [email protected]

Pull request #1690 #1690 was
updated. @nclopezo https://github.com/nclopezo, @dandugganhttps://github.com/danduggan,
@rovere https://github.com/rovere, @cmsbuildhttps://github.com/cmsbuild,
@anton-a https://github.com/anton-a, @thspeerhttps://github.com/thspeer,
@deguio https://github.com/deguio, @slava77 https://github.com/slava77,
@eliasron https://github.com/eliasron can you please check and sign
again.

—

Reply to this email directly or view it on GitHubhttps://github.com//pull/1690#issuecomment-30926392
.

ptraczyk · 2013-12-19T13:29:33Z

To clarify:
the problem with cosmics and HLT configurations that were crashing the test
jobs has been solved by removing the previously added cfg parameter and
updating the algorithm accordingly. Given this no other changes are
necessary, in particular there is no need to modify confDB, the current HLT
configuration works ok now.
The bug causing the segfaults the other jobs was found and fixed.

2013/12/19 Piotr Traczyk [email protected]

FYI this commit now contains all the modifications, it passes the tests on
my side.

2013/12/19 cmsbuild [email protected]

Pull request #1690 #1690 was
updated. @nclopezo https://github.com/nclopezo, @dandugganhttps://github.com/danduggan,
@rovere https://github.com/rovere, @cmsbuildhttps://github.com/cmsbuild,
@anton-a https://github.com/anton-a, @thspeerhttps://github.com/thspeer,
@deguio https://github.com/deguio, @slava77 https://github.com/slava77,
@eliasron https://github.com/eliasron can you please check and sign
again.

—

Reply to this email directly or view it on GitHubhttps://github.com//pull/1690#issuecomment-30926392
.

ktf · 2013-12-20T09:17:45Z

To pre12 / 71X.

cmsbuild · 2014-01-06T17:04:35Z

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1690/1903/summary.html

slava77 · 2014-01-13T13:14:38Z

This will go to 71X by default.

deguio · 2014-01-21T15:47:49Z

+1
this targets 71X. still mergeable.

ktf · 2014-01-22T13:51:47Z

Closing this. Please reopen in 71X (you can do so using the same branch you used in 70X).

upgrade lhapdfsets to 6.1.5b with CT14

ptraczyk and others added 22 commits November 28, 2013 23:41

rearranged DT segment building code. Updates to MT pattern reco. Bugf…

281dd9a

…ix in DT timing in RecoMuon/MuonIdentification

fixed compiler warnings and a memory leak

61cb6b3

performance optimizations

1d5a3d2

Add plotting scripts

f04324d

more scripts for local processing

7817f09

add more relval samples

ef1a118

review selection of segments; matching with sim; definition of angles

9692d4d

Add more plots/info to the plotter scripts

ff4f5ea

add script for summary plots

c5f9390

cosmetics

a730a52

add segment pulls

4bc1095

fix theta angle pull

c9234a1

Mirror alpha to show correctly plots made for |wheel|

36b6c6f

Mirror alpha to show correctly plots made for |wheel|

4ba8a08

style improvements

f5e2a25

style improvements

1508801

4D segment plots for MB4 as well in local mode; cosmetics

a0fee0f

add axis labels

db9025c

oops

102a3aa

update sample path

823d00b

move histogram booking to beginRun

613eb84

add plot for #fakes

44f30b3

slava77 reviewed Dec 12, 2013
View reviewed changes

Dr15Jones reviewed Dec 16, 2013
View reviewed changes

ptraczyk added 3 commits December 17, 2013 10:50

cleanup in the cfg files

0fcf589

memory allocation cleanup

da2a3e5

Merge branch 'DTSegmentFitUpdate7X' of https://github.com/namapane/cmssw

91f09a7

into DTSegmentFitUpdate7X

ptraczyk added 3 commits December 18, 2013 16:52

fix segfault

442604f

...and fix a leftover cout

754de33

remove previously added cfg parameter, update segment fit logic

65f467e

ktf closed this Jan 22, 2014

namapane mentioned this pull request Jan 22, 2014

Dt segment fit update7 x #2133

Merged

nclopezo modified the milestones: CMSSW_7_0_0, CMSSW_7_0_0_pre13 Feb 7, 2014

ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017

Merge pull request cms-sw#1690 from mkirsano/tolhapdfsets615b

b1a6698

upgrade lhapdfsets to 6.1.5b with CT14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates in DT segments reco; bugfix in DT timing in MuonIdentification #1690

Updates in DT segments reco; bugfix in DT timing in MuonIdentification #1690

namapane commented Dec 5, 2013

cmsbuild commented Dec 5, 2013

slava77 commented Dec 12, 2013

slava77 Dec 12, 2013

namapane Dec 12, 2013

slava77 commented Dec 12, 2013

slava77 commented Dec 12, 2013

ktf commented Dec 12, 2013

nclopezo commented Dec 12, 2013

slava77 commented Dec 12, 2013

Dr15Jones Dec 16, 2013

namapane commented Dec 16, 2013

Dr15Jones Dec 16, 2013

cmsbuild commented Dec 17, 2013

deguio commented Dec 17, 2013

slava77 commented Dec 17, 2013

namapane commented Dec 17, 2013

slava77 commented Dec 17, 2013

deguio commented Dec 17, 2013

ptraczyk commented Dec 18, 2013

cmsbuild commented Dec 19, 2013

ptraczyk commented Dec 19, 2013

ptraczyk commented Dec 19, 2013

ktf commented Dec 20, 2013

cmsbuild commented Jan 6, 2014

slava77 commented Jan 13, 2014

deguio commented Jan 21, 2014

ktf commented Jan 22, 2014

Updates in DT segments reco; bugfix in DT timing in MuonIdentification #1690

Updates in DT segments reco; bugfix in DT timing in MuonIdentification #1690

Conversation

namapane commented Dec 5, 2013

cmsbuild commented Dec 5, 2013

slava77 commented Dec 12, 2013

slava77 Dec 12, 2013

Choose a reason for hiding this comment

namapane Dec 12, 2013

Choose a reason for hiding this comment

slava77 commented Dec 12, 2013

slava77 commented Dec 12, 2013

ktf commented Dec 12, 2013

nclopezo commented Dec 12, 2013

slava77 commented Dec 12, 2013

Dr15Jones Dec 16, 2013

Choose a reason for hiding this comment

namapane commented Dec 16, 2013

Dr15Jones Dec 16, 2013

Choose a reason for hiding this comment

cmsbuild commented Dec 17, 2013

deguio commented Dec 17, 2013

slava77 commented Dec 17, 2013

namapane commented Dec 17, 2013

slava77 commented Dec 17, 2013

deguio commented Dec 17, 2013

ptraczyk commented Dec 18, 2013

cmsbuild commented Dec 19, 2013

ptraczyk commented Dec 19, 2013

ptraczyk commented Dec 19, 2013

ktf commented Dec 20, 2013

cmsbuild commented Jan 6, 2014

slava77 commented Jan 13, 2014

deguio commented Jan 21, 2014

ktf commented Jan 22, 2014