MiniAOD: met filter flag on bad muon

[mariadalfonso]

Here additional MET filter flags

[cmsbuild]

A new Pull Request was created by @mariadalfonso for CMSSW_8_1_X.

It involves the following packages:

PhysicsTools/PatAlgos
RecoMET/METFilters

@cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@ferencek, @TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @JyothsnaKomaragiri, @gkasieczka, @schoef, @gpetruc, @mverzett, @pvmulder this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

@cmsbuild please test

looks like the various filters are generated by copy-paste with minor modifications.
It would be better to have a more flexible filter that can handle more cases so that we do not generate new copy-pasted code that may have maintenance issues if ever needs to be updated.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15012/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15015/console

[slava77]

since this is considered not essential for rereco, I'd rather we properly review this at regular pace.
Code quality is not really at production level.

[cmsbuild]

+1
Tested at: 4764d73
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15761/15015/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15761/15015/summary.html

[cvuosalo]

@mariadalfonso: Massive copy/paste of code is not an advisable software development method for maintainable production code. Instead of five nearly identical filter classes, there should only be one which is parameterized and configurable for multiple needs. This configurability can be achieved with constructor parameters, templates, inheritance, or maybe multiple method functions.

[cvuosalo]

@mariadalfonso: The 810pre12 deadline is rapidly approaching. What is the plan for completing this PR?

[mariadalfonso]

I close these PR since I made those in a super hurry to meet the 8_0_20 re-reco deadline.

For the 81X - that target next year, if needed we can re-open other PRs that

1. rework the class as you requested in MiniAOD: met filter flag on bad muon #15761
   and allow the needed large scale testing
2. look at the Prompt-Reco H dataset with the various charged hadron PF-fixes and alignments and hw HIP fix.
3. come up with a real PF fix for the remaining muon problems.