Puppi isolation electrons mini aod rebased v2

[ishvetso]

this is a rebase of #15628

[cmsbuild]

A new Pull Request was created by @ishvetso (Ivan Shvetsov) for CMSSW_8_1_X.

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/IsolationAlgos
PhysicsTools/PatAlgos
RecoEgamma/EgammaIsolationAlgos

@cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@rappoccio, @Sam-Harper, @JyothsnaKomaragiri, @rafaellopesdesa, @imarches, @ahinzmann, @acaudron, @mmarionncern, @TaiSakuma, @lgray, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @cbernet this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14937/console

[cmsbuild]

-1

Tested at: 293ba88

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15722/14937/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests AddOn

• Unit Tests:

I found errors in the following unit tests:

---> test runtestTqafExamples had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafTopEventProducers had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test runtestTqafTopKinFitter had ERRORS

• AddOn:

I found errors in the following addon tests:

cmsRun /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-04-2300/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Mon Sep 5 03:58:41 2016-date Mon Sep 5 03:58:00 2016 s - exit: 16640

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15722/14937/summary.html

[monttj]

Shouldn't it be the same as the input for PAT Photon?

process.egmPhotonPUPPIIsolation.srcToIsolate = cms.InputTag("reducedEgamma","reducedGedPhotons")

The input for PAT photons is "gedPhotons" collection while the input for the value map is "reducedEgamma:reducedGedPhotons".

Same for electrons.

Regards,
Taejeong

[ishvetso]

I also thought that it should be gedPhotons, but I have checked the dump of the miniAOD configuration and there reducedEgamma collection is the actual input source collection.

[ishvetso]

@slava77 I'm trying to rebase -i as you requested to remove some irrelevant commits. I have started a new area and did
git rebase -i CMSSW_8_1_X_2016-09-04-0000

and I'm getting some conflicts for some reason ...:
error: could not apply 8cd34d6... few fixes

When you have resolved this problem, run "git rebase --continue".
If you prefer to skip this patch, run "git rebase --skip" instead.
To check out the original branch and stop rebasing, run "git rebase --abort".
Could not apply 8cd34d6... few fixes

should I fix that? I don't quite understand why this happens.

[slava77]

On 9/5/16 8:29 AM, Ivan Shvetsov wrote:

@slava77 https://github.com/slava77 I'm trying to rebase -i as you
requested to remove some irrelevant commits. I have started a new area
and did
git rebase -i CMSSW_8_1_X_2016-09-04-0000

and I'm getting some conflicts for some reason ...:
error: could not apply 8cd34d6
8cd34d6...
few fixes

When you have resolved this problem, run "git rebase --continue".
If you prefer to skip this patch, run "git rebase --skip" instead.
To check out the original branch and stop rebasing, run "git rebase
--abort".
Could not apply 8cd34d6
8cd34d6...
few fixes

should I fix that? I'm a bit surprised to see that.

try to follow the instructions, in case it's just for one or two commits.

Given the long history of minor commits, which doesn't really describe
that well the feature development,
I suggest to redo this with just a few descriptive commits.
(start a new test area, copy files there and apply new commits).

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15722 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AEdcbvbyJGB1I5N3U8fxFgo2kL3ZpARZks5qnDVmgaJpZM4J0oAg.

[ishvetso]

superseded by #15741