-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix nan Calo-towers, when HO is deactivated, but has energy deposit (and ECAL/HCAL do not have any energy deposits) #15706
fix nan Calo-towers, when HO is deactivated, but has energy deposit (and ECAL/HCAL do not have any energy deposits) #15706
Conversation
…collection, following Slava's suggestion
…ble; N.B.: I assume towerP4[3]==0 && E_outer>0 should only happen, if theHOIsUsed==false anyway
A new Pull Request was created by @kirschen for CMSSW_8_0_X. It involves the following packages: RecoLocalCalo/CaloTowersCreator @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
backport of #15568 .. to make the bot add a label |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 for #15706 e7b1b37
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
add precaution for deactivated HO (theHOIsUsed==false): set tower energy to tiny value to avoid nan-eta for HO-only towers (when HO is'deactivated', i.e. energy set to zero)
backport of #15568