-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLT v2.1 update (81X). #14811
HLT v2.1 update (81X). #14811
Conversation
A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_8_1_X. It involves the following packages: HLTrigger/Configuration @perrotta, @smuzaffar, @Dr15Jones, @cvuosalo, @fwyzard, @Martin-Grunewald, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@@ -20,7 +20,7 @@ class dso_internal OuterHitPhiPrediction { | |||
float originRBound) | |||
: thePhiAtVertex(phiAtVertex), theCurvature(curvature), | |||
theOriginRBound (originRBound) { | |||
assert(theCurvature.max()>0); | |||
// assert(theCurvature.max()>0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VinInn
please confirm this is OK,
so that it's not masking another problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 |
@Dr15Jones |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
I believe that this is technically speaking a regression ,at least for what concern this PR ,and removing the assert "cures" the regression. |
Please see the discussion in #13819. |
+1 |
HLT v2.1 update (81X).
Based on CMSSW_8_1_X_2016-06-01-1100.