Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix posftix and scheduled mode issue in the runMETUncertainty tool #14606

Closed
wants to merge 1,206 commits into from
Closed

Fix posftix and scheduled mode issue in the runMETUncertainty tool #14606

wants to merge 1,206 commits into from

Conversation

mmarionncern
Copy link

This PR contains a fix for specific uses of the postfix option, and another one for someone running the tool in scheduled mode.

The PR also contains a small update of the PAT tau cleaning. In case this is forbidden for 80X, as that change affects the miniAOD reprocessing, it will be removed.

Packages touched :

  • PhysicsTools/PatUtils
  • PhysicsTools/PatAlgos

Changes expected : tau cleaning

Validation plots : http://mmarionn.web.cern.ch/mmarionn/MET/Validation_8_0_X/
(black line is the reference, red line is after the changes)

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone May 23, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmarionncern for CMSSW_8_0_X.

It involves the following packages:

PhysicsTools/PatAlgos
PhysicsTools/PatUtils

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @rappoccio, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented May 23, 2016

@mmarionncern
we need a PR in 81X as well.
This is where the code will be integrated first.

@mmarionncern mmarionncern mentioned this pull request May 23, 2016
Merged
@slava77
Copy link
Contributor

slava77 commented May 23, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 23, 2016 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13138/console

@slava77
Copy link
Contributor

slava77 commented May 23, 2016

contains a small update of the PAT tau cleaning. In case this is forbidden for 80X
yes, changes in miniAOD are not allowed until further notice (miniAOD v3 processing campaign, probably post-ICHEP)

@cmsbuild
Copy link
Contributor

-1

Tested at: 6a5df3d

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6a5df3d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14606/13138/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14606/13138/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14606/13138/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestSimCalorimetryHGCalSimProducers had ERRORS
---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
134.911 step3 
runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2/step3_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2.log
1330.0 step3 
runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
135.4 step3 
runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
50202.0 step3 
runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
25202.0 step3 
runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6a5df3d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14606/13138/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14606/13138/git-merge-result

@cmsbuild
Copy link
Contributor

Pull request #14606 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented May 24, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 24, 2016 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13157/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 14e2b9b

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14606/13157/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
134.911 step3

runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2/step3_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2.log
135.4 step3 
runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
1306.0 step3 
runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
1330.0 step3 
runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
50202.0 step3 
runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
25202.0 step3 
runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

cmsbuild and others added 9 commits August 23, 2016 17:48
@cmsbuild
Merge pull request cms-sw#15430 from minano/New_Plots_Cluster_Occupan…
2ed8fc0 
…cy_Phi_80

New plots NofClusters vs Phi added for barrel and endcap
@cmsbuild
Merge pull request cms-sw#15538 from Martin-Grunewald/TSGeos80X
29ffdb2 
TSG test files from TSG eos location (80X)
@davidlange6
Merge pull request cms-sw#15567 from smuzaffar/cmssw_das_client-80X
422d2ef 
Internal das client python module to call das_client wrapper
@cmsbuild
Merge pull request cms-sw#15552 from mbandrews/GlobalQt80X
e65eaed 
Set Global Quality to show RED when FE is disabled
@cmsbuild
Merge pull request cms-sw#15515 from fioriNTU/FixTkMap
e09ca1d 
Fix for Tracker Maps and Shifter Summary
@cmsbuild
Merge pull request cms-sw#15439 from afiqaize/rhoCorr80X
e2ad251 
rhoCorr binned in eta 80X, apply rhoCorr for H/E
@cmsbuild
Merge pull request cms-sw#15544 from jruizvar/L2Mu80X
0f88d9d 
Increase pt threshold of L2Mu NoBPTX path (80X)
@cmsbuild
Merge pull request cms-sw#15533 from mtosi/fixV0Monitoring80x
eaa96a4 
push my-cmssw fixV0Monitoring
fix conflict 80X
e490e76
@cmsbuild
Copy link
Contributor

Pull request #14606 was updated. @cmsbuild, @cvuosalo, @slava77, @montjj, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #14606 was updated. @ghellwig, @cvuosalo, @cerminar, @cmsbuild, @rekovic, @franzoni, @montjj, @slava77, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please check and sign again.

@mmarionncern
Copy link
Author

mmarionncern commented Aug 26, 2016 •
edited
Loading

I made a rebase to fix the conflicts, appeared since the PR was holded, but it looks like it should not have been done that way.... currently investigating

@mmarionncern mmarionncern mentioned this pull request Aug 26, 2016
Closed
@mmarionncern
Copy link
Author

I prefered to remake a new PR on top of the current CMSSW_8_0_X version rather than keeping that PR.
The new PR is here : #15616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending analysis-pending comparison-pending db-pending hold l1-pending new-package-pending orp-pending pending-signatures reconstruction-pending tests-pending
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.