-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds HLTPixelActivityHFSumEnergyFilter module (superseeds #12483) #12487
adds HLTPixelActivityHFSumEnergyFilter module (superseeds #12483) #12487
Conversation
A new Pull Request was created by @mverwe (Marta Verweij) for CMSSW_7_5_X. It involves the following packages: HLTrigger/special @Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
@cmsbuild please test |
@mverwe please use "Edit" button at the top and change the title of the PR to something meaningful and self-descriptive |
The tests are being triggered in jenkins. |
This must be a normal (stream or global) EDFilter, not an HLTFilter, as it does not (and can not!) save any TriggerObjects. Please make the change. |
-1 |
please test |
The tests are being triggered in jenkins. |
We've addressed all comments. Let us know in case of further remarks. |
Pull request #12487 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
merge all new code |
adds HLTPixelActivityHFSumEnergyFilter module (superseeds #12483)
BTW, is there a PR for 76X as well? Please make one! |
@Martin-Grunewald The PR for 76X will be done asap |
pixel vs HF energy filter (76X version of #12487)
This PR superseeds #12483
Adds HLTPixelActivityHFSumEnergyFilter module. This filter checks correlation between number of pixel clusters and HF energy sum. The idea is to have a filter firing when the expected correlation is broken.
Remark 1 : This module is NOT for the pp reference run.
Remark 2 : This module is for PbPb run.
@kkrajczar
@icali
@ttrk