-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another fix to TrackingVertex->TrackingParticle links in premixing #12391
Another fix to TrackingVertex->TrackingParticle links in premixing #12391
Conversation
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X. It involves the following packages: SimGeneral/DataMixingModule @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
@Degano you are the release manager for this. |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Another fix to TrackingVertex->TrackingParticle links in premixing
Validation of 760 revealed that even with #11854 there are some problems left in TrackingParticle<->TrackingVertex refs
https://hypernews.cern.ch/HyperNews/CMS/get/relval/4261/13.html
This PR provides two additional fixes
Tested in 760 with wfs 250199+250202.0 (latter manually configured to use the output of the former for premixed pileup events). Expecting differences in all validation plots using the TrackingParticles via TrackingVertex, e.g.