Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another fix to TrackingVertex->TrackingParticle links in premixing #12391

Merged

Conversation

makortel
Copy link
Contributor

Validation of 760 revealed that even with #11854 there are some problems left in TrackingParticle<->TrackingVertex refs
https://hypernews.cern.ch/HyperNews/CMS/get/relval/4261/13.html
This PR provides two additional fixes

Tested in 760 with wfs 250199+250202.0 (latter manually configured to use the output of the former for premixed pileup events). Expecting differences in all validation plots using the TrackingParticles via TrackingVertex, e.g.

  • in primary vertex validation anything vs. TrackingVertex sum(pT^2)
  • in V0 validation, K0/Lambda fake rate

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X.

It involves the following packages:

SimGeneral/DataMixingModule

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/L2's to mark it as on hold
  • merge: L1 to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Nov 12, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9676/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Nov 13, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Nov 14, 2015
Another fix to TrackingVertex->TrackingParticle links in premixing
@davidlange6 davidlange6 merged commit 0426797 into cms-sw:CMSSW_8_0_X Nov 14, 2015
@makortel makortel deleted the fixTrackingParticlePremixing branch October 20, 2016 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants