phase1Pixel era validation additions

[mark-grimes]

Second tranche of phase1Pixel era changes, adding on from #12275. This one is validation customisations which should be equivalent to the phase1TkCustoms.customise_Validation function.

There should be no change whatsoever unless the Run2_2017 era is active (the only top-level era that contains phase1Pixel).

I'm assuming HLTValidation_cff.py is not auto-generated (I never know which HLT stuff is or isn't). If it is I'll have to find somewhere else to put the change.

@atricomi, @delaere:
Note the lines...

process.validation_step.remove(process.HLTSusyExoVal)
process.validation_step.remove(process.relvalMuonBits)

...have not been ported from the customisation to the era. Neither appear to still be in use in 8_0_X. HLTSusyExoVal never seems to be used by anything - there is a HLTSusyExoValSeq though, do you know if that should be taken out? I'll leave it as is unless you say otherwise.
relvalMuonBits appears to be taken out for all sequences now, it's commented out in HLTriggerOffline/Muon/python/HLTMuonVal_cff.py#L15

[cmsbuild]

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_8_0_X.

phase1Pixel era validation additions

It involves the following packages:

HLTriggerOffline/Common
Validation/RecoTrack

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @cerati, @wmtford, @istaslis, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' 'please test with cms-sw/cmsdist#PR' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[atricomi]

I guess it was never used indeed and can be taken out.
Cheers
Alessia
Il giorno 10/nov/2015, alle ore 18:03, Mark Grimes [email protected] ha scritto:

Second tranche of phase1Pixel era changes, adding on from #12275. This one is validation customisations which should be equivalent to the phase1TkCustoms.customise_Validation function.

There should be no change whatsoever unless the Run2_2017 era is active (the only top-level era that contains phase1Pixel).

I'm assuming HLTValidation_cff.py is not auto-generated (I never know which HLT stuff is or isn't). If it is I'll have to find somewhere else to put the change.

@atricomi, @delaere:
Note the lines...

process.validation_step.remove(process.HLTSusyExoVal)
process.validation_step.remove(process.relvalMuonBits)
...have not been ported from the customisation to the era. Neither appear to still be in use in 8_0_X. HLTSusyExoVal never seems to be used by anything - there is a HLTSusyExoValSeq though, do you know if that should be taken out? I'll leave it as is unless you say otherwise.
relvalMuonBits appears to be taken out for all sequences now, it's commented out in HLTriggerOffline/Muon/python/HLTMuonVal_cff.py#L15

You can view, comment on, or merge this pull request online at:

#12359

Commit Summary

Add an phase1Pixel era command equivalent to "process.validation_step.remove(process.PixelTrackingRecHitsValid)"
Add an phase1Pixel era command equivalent to "process.validation_step.remove(process.hltHiggsValidator)"
File Changes

M HLTriggerOffline/Common/python/HLTValidation_cff.py (5)
M Validation/RecoTrack/python/SiTrackingRecHitsValid_cff.py (4)
Patch Links:

https://github.com/cms-sw/cmssw/pull/12359.patch
https://github.com/cms-sw/cmssw/pull/12359.diff
—
Reply to this email directly or view it on GitHub.

[boudoul]

it was used (and needed) for SLHC release but indeed not anymore for 8X

[atricomi]

For Phase1?
Ok… good to know, I never saw it
Il giorno 10/nov/2015, alle ore 18:23, boudoul [email protected] ha scritto:

it was used (and needed) for SLHC release but indeed not anymore for 8X

—
Reply to this email directly or view it on GitHub.