Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Castor 2015 Scenarios #12350

Merged
merged 6 commits into from
Nov 16, 2015
Merged

Castor 2015 Scenarios #12350

merged 6 commits into from
Nov 16, 2015

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Nov 10, 2015

  • Add Castor geometry scenarios with position for 2015

@ianna
Copy link
Contributor Author

ianna commented Nov 10, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Nov 10, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9621/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_8_0_X.

Castor 2015 Scenarios

It involves the following packages:

CondTools/Geometry
Configuration/Geometry
Geometry/CMSCommonData
Geometry/ForwardCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @ggovi can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @apfeiffer1 this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' 'please test with cms-sw/cmsdist#PR' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor Author

ianna commented Nov 10, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1
Tested at: 7818344
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12350/9621/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6674b04
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12350/9621/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12350/9621/git-merge-result

@cmsbuild
Copy link
Contributor

Pull request #12350 was updated. @ggovi, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please check and sign again.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12350/9621/summary.html

@ianna
Copy link
Contributor Author

ianna commented Nov 11, 2015

+1

@ggovi
Copy link
Contributor

ggovi commented Nov 11, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 16, 2015
@cmsbuild
Merge pull request #12350 from ianna/castor-2015-scenarios
cb4ade5 
Castor 2015 Scenarios
@cmsbuild cmsbuild merged commit cb4ade5 into cms-sw:CMSSW_8_0_X Nov 16, 2015
@ianna ianna mentioned this pull request Nov 16, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed geometry-approved tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.
4 participants
@ianna @cmsbuild @ggovi @davidlange6