pass isRepacked flag to config builder if set in a scenario #12326

slava77 · 2015-11-09T17:42:15Z

default isRepacked is not set, leaving it to the configBuilder defaults
HeavyIonsRun2 has isRepacked=True (corresponds to a swap of rawDataCollector with rawDataRepacker, which is happening in HLT, different from regular pp/cosmics data taking)

The python config Configuration/DataProcessing/test/RunPromptReco.py, which is useful in local tests,
has options --isRepacked or --isNotRepacked to override the isRepacked parameter.

Passing arguments to the T0 setup is more complicated and the flexibility to choose repacked or non-repacked inputs is not available with this PR.
The easiest is to introduce a new scenario (e.g. HeavyIonsRun2frompp )

…to true (unless an override is provided)

…(more parameters and changes need to be made in WMCore and in T0 projects), only for local tests

slava77 · 2015-11-09T17:42:24Z

@cmsbuild please test

cmsbuild · 2015-11-09T17:46:10Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9544/console

cmsbuild · 2015-11-09T17:46:12Z

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_5_X.

pass isRepacked flag to config builder if set in a scenario

It involves the following packages:

Configuration/DataProcessing

@cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' 'please test with cms-sw/cmsdist#PR' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

cmsbuild · 2015-11-09T19:25:02Z

-1

Tested at: a8875ad
I found errors in the following unit tests:

---> test TestConfigDP had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12326/9544/summary.html

slava77 · 2015-11-09T19:32:46Z

oops, fix is coming soon

slava77 · 2015-11-09T19:47:40Z

@cmsbuild please test
[I ran runtests this time and they pass OK; no changes are expected otherwise]

cmsbuild · 2015-11-09T19:51:14Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9553/console

cmsbuild · 2015-11-09T19:51:15Z

Pull request #12326 was updated. @cmsbuild, @franzoni, @davidlange6 can you please check and sign again.

cmsbuild · 2015-11-09T21:04:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12326/9544/summary.html

cmsbuild · 2015-11-09T22:09:37Z

+1
Tested at: e91576a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12326/9553/summary.html

cmsbuild · 2015-11-09T23:40:38Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12326/9553/summary.html

slava77 · 2015-11-10T02:34:54Z

no changes appear in jenkins tests as expected.
manual comparisons of prompt reco configs generated with RunPromptReco.py show expected changes in the rawdata input tag parameters.

davidlange6 · 2015-11-10T08:04:33Z

Configuration/DataProcessing/test/RunPromptReco.py

@@ -29,6 +29,8 @@ def __init__(self):
        self.alcaRecos = None
        self.PhysicsSkims = None
        self.dqmSeq = None
+        self.setRepacked = False
+        self.isRepacked = False


@slava77 - I think this would be more consistent if the default of isRepacked here is True (as that is default elsewhere in the PR)

On 11/10/15 12:04 AM, David Lange wrote:

In Configuration/DataProcessing/test/RunPromptReco.py
#12326 (comment):

@@ -29,6 +29,8 @@ def init(self):
self.alcaRecos = None
self.PhysicsSkims = None
self.dqmSeq = None

self.setRepacked = False

self.isRepacked = False

@slava77 https://github.com/slava77 - I think this would be more
consistent if the default of isRepacked here is True (as that is default
elsewhere in the PR)

I'm not sure I understand the logic.

As defined here, the defaults in this file leave it to the corresponding
scenarios to set their values.
The isRepacked has no effect if setRepacked is false.
If the defaults need to be reset (the main purpose of these flags here),
and so far it's only needed in HI, it would be reset to false.

I can change, if you confirm that you still want it at a true value.
(the file is useful only in local tests; in T0 perspective, these flags
are invisible)

—
Reply to this email directly or view it on GitHub
https://github.com/cms-sw/cmssw/pull/12326/files#r44378627.

ah - good point. Ok - thanks

…gn626/hiRepackSettings pass isRepacked flag to config builder if set in a scenario

slava77devel added 2 commits November 9, 2015 18:30

pass isRepacked flag to the config builder: HeavyIonsRun2 has it set …

8235b52

…to true (unless an override is provided)

allow to override the isRepacked flag; this is not very useful at T0 …

a8875ad

…(more parameters and changes need to be made in WMCore and in T0 projects), only for local tests

cmsbuild added this to the Next CMSSW_7_5_X milestone Nov 9, 2015

cmsbuild added operations-pending pending-signatures tests-pending orp-pending comparison-pending labels Nov 9, 2015

cmsbuild added tests-started and removed tests-pending labels Nov 9, 2015

cmsbuild added tests-rejected and removed tests-started labels Nov 9, 2015

pass args by reference

e91576a

cmsbuild added tests-pending and removed tests-rejected labels Nov 9, 2015

cmsbuild added tests-started and removed tests-pending labels Nov 9, 2015

cmsbuild added comparison-available and removed comparison-pending labels Nov 9, 2015

cmsbuild removed the tests-started label Nov 9, 2015

cmsbuild added the tests-approved label Nov 9, 2015

davidlange6 reviewed Nov 10, 2015
View reviewed changes

davidlange6 added a commit that referenced this pull request Nov 10, 2015

Merge pull request #12326 from slava77/CMSSW_7_5_X_2015-11-05-2300/si…

d66c207

…gn626/hiRepackSettings pass isRepacked flag to config builder if set in a scenario

davidlange6 merged commit d66c207 into cms-sw:CMSSW_7_5_X Nov 10, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pass isRepacked flag to config builder if set in a scenario #12326

pass isRepacked flag to config builder if set in a scenario #12326

slava77 commented Nov 9, 2015

slava77 commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

slava77 commented Nov 9, 2015

slava77 commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

slava77 commented Nov 10, 2015

davidlange6 Nov 10, 2015

slava77 Nov 10, 2015

davidlange6 Nov 10, 2015

pass isRepacked flag to config builder if set in a scenario #12326

pass isRepacked flag to config builder if set in a scenario #12326

Conversation

slava77 commented Nov 9, 2015

slava77 commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

slava77 commented Nov 9, 2015

slava77 commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

cmsbuild commented Nov 9, 2015

slava77 commented Nov 10, 2015

davidlange6 Nov 10, 2015

Choose a reason for hiding this comment

slava77 Nov 10, 2015

Choose a reason for hiding this comment

davidlange6 Nov 10, 2015

Choose a reason for hiding this comment