Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of #12313: fix systematic misalignment tool #12314

Merged

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Nov 8, 2015

Fix the test script which hasn't been working for a while, and simplify its use

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2015

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_7_6_X.

Backport of #12313: fix systematic misalignment tool

It involves the following packages:

Alignment/TrackerAlignment

@cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tlampen this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Nov 9, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9521/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

@hroskes
Copy link
Contributor Author

hroskes commented Nov 9, 2015

@cmsbuild

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

Pull request #12314 was updated. @cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Nov 9, 2015

@cmsbuild please test

@mmusich
Copy link
Contributor

mmusich commented Nov 9, 2015

+1
provided Jenkins agrees

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9538/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Nov 11, 2015
@davidlange6 davidlange6 merged commit 9f3186f into cms-sw:CMSSW_7_6_X Nov 11, 2015
@hroskes hroskes deleted the fix-systematic-misalignments-76X branch November 11, 2015 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants