-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with pythia8 212 and features from 76X #12286
Conversation
To be built with cmsdist #1946 |
A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for CMSSW_7_5_X. Compatibility with pythia8 212 and features from 76X It involves the following packages: GeneratorInterface/Pythia8Interface @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please review it and eventually sign? Thanks. |
-1 --- Registered EDM Plugin: GeneratorInterfaceCascadeInterface >> Leaving Package GeneratorInterface/CascadeInterface >> Package GeneratorInterface/CascadeInterface built >> Building shared library tmp/slc6_amd64_gcc491/src/FastSimulation/ParticleDecay/src/FastSimulationParticleDecay/libFastSimulationParticleDecay.so Copying tmp/slc6_amd64_gcc491/src/FastSimulation/ParticleDecay/src/FastSimulationParticleDecay/libFastSimulationParticleDecay.so to productstore area: /build/cmsbuild/jenkins-workarea/workspace/test-cmsdist-cmssw-test-pr/CMSSW_7_5_X_2015-11-05-2300/src/FastSimulation/ParticleDecay/plugins/TestPythiaDecays.cc:79:28: error: 'string' was not declared in this scope std::map > knownDecayModes; ^ /build/cmsbuild/jenkins-workarea/workspace/test-cmsdist-cmssw-test-pr/CMSSW_7_5_X_2015-11-05-2300/src/FastSimulation/ParticleDecay/plugins/TestPythiaDecays.cc:79:28: note: suggested alternatives: In file included from /afs/cern.ch/cms/sw/ReleaseCandidates/volA/slc6_amd64_gcc491/external/gcc/4.9.1-cms/include/c++/4.9.1/iosfwd:39:0, from /afs/cern.ch/cms/sw/ReleaseCandidates/volA/slc6_amd64_gcc491/external/gcc/4.9.1-cms/include/c++/4.9.1/memory:72, you can see the results of the tests here: |
@mkirsano (writing again) After a manual double check I confirm that's a legitimate error found by the new script that tests this cmssw PR against the cmsdist one. |
Somehow this was not needed in other branches. |
@mkirsano I'll trigger the (custom) tests again. |
please test with cms-sw/cmsdist#1946 |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
@davidlange6 should we proceed with the merging of this one along its cmsdist part? |
Compatibility with pythia8 212 and features from 76X
No description provided.