-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up from conddb V1 code #12269
Clean up from conddb V1 code #12269
Conversation
A new Pull Request was created by @ggovi for CMSSW_8_0_X. Clean up from conddb V1 code It involves the following packages: Alignment/CommonAlignmentProducer @diguida, @danduggan, @cerminar, @cmsbuild, @franzoni, @deguio, @ggovi, @mmusich, @vanbesien can you please review it and eventually sign? Thanks. |
@cmsbuild |
please test |
The tests are being triggered in jenkins. |
@@ -1,185 +0,0 @@ | |||
#include "CondCore/DBCommon/interface/DbSession.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmusich we could provide SOME replacement but I have no idea what this thing was meant for.
@ggovi for me it is fine, provided that we look at the splitting IOV request from TkAl. |
+1 |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Step 0. Remove dependencies on CondCore/IOVService