Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up from conddb V1 code #12269

Merged
merged 1 commit into from
Nov 12, 2015

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Nov 5, 2015

Step 0. Remove dependencies on CondCore/IOVService

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

A new Pull Request was created by @ggovi for CMSSW_8_0_X.

Clean up from conddb V1 code

It involves the following packages:

Alignment/CommonAlignmentProducer
Calibration/Tools
CaloOnlineTools/HcalOnlineDb
DQM/SiStripHistoricInfoClient
DQMOffline/Alignment
DQMServices/Diagnostic

@diguida, @danduggan, @cerminar, @cmsbuild, @franzoni, @deguio, @ggovi, @mmusich, @vanbesien can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @barvic, @tlampen, @mschrode, @mmusich, @threus, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ggovi
Copy link
Contributor Author

ggovi commented Nov 5, 2015

@cmsbuild
please test

@diguida
Copy link
Contributor

diguida commented Nov 5, 2015

please test
@ggovi the please test should appear in the first line of the comment :-)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9478/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

@@ -1,185 +0,0 @@
#include "CondCore/DBCommon/interface/DbSession.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggovi @diguida are you going to provide a tool allowing to split the IOVs suitable for v2? I believe this would be highly welcome from the tracker alignment group @mschrode @tlampen

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmusich we could provide SOME replacement but I have no idea what this thing was meant for.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

@ggovi
Copy link
Contributor Author

ggovi commented Nov 6, 2015

@diguida @mmusich any objection from AlCa?

@diguida
Copy link
Contributor

diguida commented Nov 10, 2015

@ggovi for me it is fine, provided that we look at the splitting IOV request from TkAl.

@mmusich
Copy link
Contributor

mmusich commented Nov 10, 2015

+1

@deguio
Copy link
Contributor

deguio commented Nov 10, 2015

+1
@danduggan please scream now if you see something wrong... some class is removed.
ciao and thanks,
F.

@ggovi
Copy link
Contributor Author

ggovi commented Nov 11, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@danduggan
Copy link
Contributor

thanks @deguio, i believe @threus removed all the current hDQM work into a different repo. Tomas - holler if you still need something here, but to me this all looks like it can go.

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 12, 2015
@cmsbuild cmsbuild merged commit 76eb5d0 into cms-sw:CMSSW_8_0_X Nov 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants