Level-1 Trigger changes for HI Firmware #12176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 20, 2015 22:25
In addition, switch from vector of doubles to LUT for PUM0 table.
…s-l1t-offline * cms-l1t-offline/l1t-devel-CMSSW_7_6_0_pre1-CaloParamsUpdate: Refactor CaloParams into CaloParamsHelper Conflicts: L1Trigger/L1TCalorimeter/src/PUSubtractionMethods.cc L1Trigger/L1TCalorimeter/src/firmware/Stage1Layer2JetAlgorithmImpHI.cc L1Trigger/L1TCalorimeter/src/firmware/Stage1Layer2SingleTrackHI.cc
* richard-cms/HIL1_FirmwareMatching_760p7: build fixes commit current HI status, will move to pre7 shortly use correct CaloParams values for HI algos centrality verbosity changes reorganize single track algo egamma verbosity and also iso/non-iso swap updates to verbosity for egammas change the verbosity use a tunable mask to zero the walls change verbosity levels switch to integer division switch back to 3x3 jet finder for tests turn on high verbosity for HI algos Refactor CaloParams into CaloParamsHelper Conflicts: L1Trigger/L1TCalorimeter/test/SimL1Emulator_Stage1.py
* richard-cms/HIL1_FirmwareMatching_760p7: build fixes commit current HI status, will move to pre7 shortly use correct CaloParams values for HI algos centrality verbosity changes reorganize single track algo egamma verbosity and also iso/non-iso swap updates to verbosity for egammas change the verbosity use a tunable mask to zero the walls change verbosity levels switch to integer division switch back to 3x3 jet finder for tests turn on high verbosity for HI algos Refactor CaloParams into CaloParamsHelper
* richard-cms/HIL1_FirmwareMatching_760p7: (26 commits) do not set node version manually, remove PUSParam LUT fix CaloParamsHelper so that multiple setting of masks doesn't break things extended centrality fixes fixes for extended centrality fix egamma HI bug don't forget new LUT file: switch MB trigger to use parameters extend centrality algo and add alternative MB algo reduce verbosity fix typo remove background subtraction for ETT for HI running switch to new HI parameters instead of overloading old ones build fixes commit current HI status, will move to pre7 shortly use correct CaloParams values for HI algos centrality verbosity changes reorganize single track algo egamma verbosity and also iso/non-iso swap updates to verbosity for egammas change the verbosity ...
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
+1 |
|
@ggovi ping :-) |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
fully-signed
db-approved
and removed
db-pending
pending-signatures
labels
|
@davidlange6 can you please merge this? It is required in order to integrate the HI MC GT with the new L1T menu inside, otherwise we have a SEGV. |
|
+1 |
cmsbuild
added a commit
that referenced
this pull request
Dec 16, 2015
Level-1 Trigger changes for HI Firmware
cmsbuild
added a commit
that referenced
this pull request
Jan 6, 2016
Level-1 Trigger changes for HI Firmware (76X backport of #12176)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a large set of changes for the Level-1 Trigger emulator to match the Heavy Ion Level 1 firmware, including several improvements to how the Stage-1 CaloParams are handled.
Heavy Ion data taking will be in 75X, so this will be backported to 76X and 75X.
Eyes from the Stage-2 people would be very helpful to make sure I didn't mess up any Stage-2 code in the process.