allow user to select vtx or beamspot covariance

[fojensen]

fixed a bug where the switch to allow the user to use the vertex instead of the beamspot did not correspondingly use the vertex as a reference to calculate the 3D & 2D decay significance

[slava77]

@cmsbuild please test
@fojensen Frank, I suppose PRs for 75X and 76X are coming soon

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9201/console

[cmsbuild]

A new Pull Request was created by @fojensen (Frank Jensen) for CMSSW_7_4_X.

allow user to select vtx or beamspot covariance

It involves the following packages:

RecoVertex/V0Producer

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[fojensen]

@slava77
once this goes through smoothly I was going submit the other two

On Mon, Oct 26, 2015 at 8:43 AM, Slava Krutelyov
[email protected] wrote:

@cmsbuild please test
@fojensen Frank, I suppose PRs for 75X and 76X are coming soon

—
Reply to this email directly or view it on GitHub.

[cmsbuild]

+1
Tested at: f054e42
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12097/9201/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12097/9201/summary.html

[slava77]

+1

for #12097 f054e42

• select correct covariance for V0 reco with "useVertex" (non-default option)
• jenkins tests pass and comparisons with baseline show no differences

@davidlange6 this will be needed for reference pp for HI

@fojensen please prepare 75X/76X/80X PRs

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[fojensen]

@slava77

I do not see my original 76x PR in the IB list:
#11699
https://cmssdt.cern.ch/SDT/html/showIB.html
I would like to use the IB to apply the fix
(as you can tell I found the 80X and the 75X)
thank you

On Tue, Oct 27, 2015 at 8:08 PM, Slava Krutelyov [email protected]
wrote:

+1

for #12097 #12097 f054e42
f054e42

• select correct covariance for V0 reco with "useVertex" (non-default
  option)
• jenkins tests pass and comparisons with baseline show no differences

@davidlange6 https://github.com/davidlange6 this will be needed for
reference pp for HI

@fojensen https://github.com/fojensen please prepare 75X/76X/80X PRs

—
Reply to this email directly or view it on GitHub
#12097 (comment).

[slava77]

Frank, the #11699 was merged on Oct 9 (as you can see from the PR itself).
The showIB page displays only recent merges (the past 10 days or so).
You can use 760pre7 for the tests
https://github.com/cms-sw/cmssw/releases/CMSSW_7_6_0_pre7

[davidlange6]

+1