-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding HBHENegativeNoise bit to HcalRecHitFlagsToBeExcluded - 76X #11924
Adding HBHENegativeNoise bit to HcalRecHitFlagsToBeExcluded - 76X #11924
Conversation
A new Pull Request was created by @cmsbuild for CMSSW_8_0_X. Adding HBHENegativeNoise bit to HcalRecHitFlagsToBeExcluded - 76X It involves the following packages: RecoMET/METProducers @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
+1
|
@cmsbuild please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
…oBeExcluded Adding HBHENegativeNoise bit to HcalRecHitFlagsToBeExcluded - 76X
Adding HBHENegativeNoise bit to the HcalRecHitFlagsToBeExcluded list, so that NEF related quantities (nnegativenoise_, negativenoisee_, negativenoiseet_) are correctly computed in HcalNoiseInfoProducer once the NEF severity level is raised as in PR #11667 .
Otherwise they will always compute to be zero.
(please see: http://cmslxr.fnal.gov/lxr/source/RecoMET/METProducers/src/HcalNoiseInfoProducer.cc?v=CMSSW_7_6_0_pre2#0574)
Automatically ported from CMSSW_7_6_X #11751 (original by @dertexaner).