Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

74X "cumulative" Noise flags re-arrangement (backporting of two merged + one yet unmerged 76X PRs) #11736

Closed

Conversation

abdoulline
Copy link

Backporting of merged 76X PR #11481

  • lowering SeverityLevel of HFDigiTime and HBHEFlatNoise flags for 25ns
  • removal of PFlow HF time-based selection

and adding also merged in 76X #11667

  • replacing SpikeNoise flag by NegativeNoise one

Finally: adding HBHENegativeNoise bit to HcalRecHitFlagsToBeExcluded as in 76X
#11751

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @abdoulline (Salavat Abdullin) for CMSSW_7_4_X.

74X: "cumulative" resubmission of the two PRs merged in 76X

It involves the following packages:

Configuration/DataProcessing
Configuration/StandardSequences

@cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@abdoulline abdoulline changed the title 74X: "cumulative" resubmission of the two PRs merged in 76X 74X "cumulative" resubmission of two PRs merged in 76X: HCAL Noise flags re-arrangements Oct 12, 2015
@cmsbuild
Copy link
Contributor

Pull request #11736 was updated. @cmsbuild, @cvuosalo, @franzoni, @davidlange6, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Oct 14, 2015

@cmsbuild please test
[to have a record of test completion and the effects here]

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8811/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Oct 14, 2015

@abdoulline
it may help to update the title of the PR

@abdoulline abdoulline changed the title 74X "cumulative" resubmission of two PRs merged in 76X: HCAL Noise flags re-arrangements 74X "cumulative" Noise flags re-arrangement (backporting of two merged + one yet unmerged 76X PRs) Oct 14, 2015
@slava77
Copy link
Contributor

slava77 commented Oct 21, 2015

+1

for #11736 0ece623

This PR will stay in limbo.
Needed only if a special release is to be made in 74X for targeted pp reprocessing.
(expectations for this are fairly low)

@davidlange6 davidlange6 modified the milestones: Next CMSSW_7_4_X, Next CMSSW_7_6_X Oct 24, 2015
@davidlange6 davidlange6 modified the milestones: Next CMSSW_7_6_X, Next CMSSW_7_4_X Oct 24, 2015
@cmsbuild cmsbuild modified the milestones: Next CMSSW_7_4_X, Next CMSSW_7_6_X Oct 24, 2015
@slava77
Copy link
Contributor

slava77 commented Nov 3, 2016

@davidlange6
I think that this PR can be closed
Even if we do something with 2015, it will be 76X.

@abdoulline abdoulline deleted the abdoulline/HFDigiTime_fix74X branch April 13, 2017 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants