Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scouting producers now ignore missing input collections (76X) #11633

Merged
merged 1 commit into from
Oct 6, 2015
Merged

Scouting producers now ignore missing input collections (76X) #11633

merged 1 commit into from
Oct 6, 2015

Conversation

duanders
Copy link
Contributor

@duanders duanders commented Oct 5, 2015

Port of #11627 to 76X

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 5, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2015

A new Pull Request was created by @duanders (Dustin Anderson) for CMSSW_7_6_X.

Scouting producers now ignore missing input collections (76X)

It involves the following packages:

HLTrigger/JetMET

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2015

+1
Tested at: d5169cc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11633/8614/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11633/8614/summary.html

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

davidlange6
davidlange6 reviewed Oct 6, 2015
View reviewed changes
HLTrigger/JetMET/plugins/HLTScoutingCaloProducer.cc
std::auto_ptr<double> outMetPhi(new double(-999));
if(doMet && iEvent.getByToken(metCollection_, metCollection)){
outMetPt.reset(new double(metCollection->front().pt()));
outMetPhi.reset(new double(metCollection->front().phi()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duanders - why reset and new here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidlange6 - sorry, I see that this could just be *outMetPhi = metCollection->front().phi(). mistake on my part.

cmsbuild added a commit that referenced this pull request Oct 6, 2015
@cmsbuild
Merge pull request #11633 from duanders/scoutingproducerrevamp_76X
b5e6c43 
Scouting producers now ignore missing input collections (76X)
@cmsbuild cmsbuild merged commit b5e6c43 into cms-sw:CMSSW_7_6_X Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed hlt-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
4 participants
@duanders @cmsbuild @Martin-Grunewald @davidlange6