Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flavor bugfix in jetTools.py (74X) #11503

Conversation

ferencek
Copy link
Contributor

Backport of #11501

Update (Oct. 1, 2015): Included backport of #11612

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_4_X.

Flavor bugfix in jetTools.py (74X)

It involves the following packages:

PhysicsTools/JetExamples
PhysicsTools/JetMCAlgos
PhysicsTools/PatAlgos

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Sep 26, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

Pull request #11503 was updated. @cmsbuild, @vadler, @monttj can you please check and sign again.

@ferencek
Copy link
Contributor Author

@monttj, could you please sign this PR. Thanks

@ferencek
Copy link
Contributor Author

Now that there are no active MiniAOD campaigns in 74X, I suggest this PR gets merged.

@slava77
Copy link
Contributor

slava77 commented Jan 14, 2016

@ferencek MC requests are still coming and being processed (so far with older release);
there is also a 0T reprocessing campaign about to start.
So, 74X is still pretty active.

@slava77
Copy link
Contributor

slava77 commented Jan 14, 2016

@cmsbuild please test
(at least to have a record of the tests results)

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10497/console

@ferencek
Copy link
Contributor Author

@slava77, thanks for the info. MC requests should be unaffected but MiniAOD for 0T reprocessing, on the other hand, would be affected. So I guess it is best to wait until all MiniAOD campaigns are completed.

@slava77
Copy link
Contributor

slava77 commented Jan 14, 2016

sorry, 0T is in 76X.
MC injections are still ongoing though.

@slava77
Copy link
Contributor

slava77 commented Jan 14, 2016

I think further plans for 74X can be discussed in the ORP (no more changes is still an easier choice).
IMO, if we let changes to happen, it will be more than just this PR.

@ferencek
Copy link
Contributor Author

In that case, there is no problem with merging this PR since the only data tier it affects is MiniAOD. This and possibly other 74X PR would still be useful for some analysis-level work until a complete migration to 76X is made.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ferencek
Copy link
Contributor Author

No longer relevant after 76X re-reco. Closing

@ferencek ferencek closed this Jan 20, 2016
@ferencek ferencek deleted the JetFlavorFixes_from-CMSSW_7_4_12 branch January 20, 2016 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants