Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-alca17 Update the AlCaReco part for IsoTrack and Muon part #10115

Merged
merged 3 commits into from
Nov 3, 2015

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jul 9, 2015

Make the code compatible to mult-threading
Modify the selection to improve throughput in endcap region
Get rid of unused parameters from the code and parameter lists

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

A new Pull Request was created by @bsunanda for CMSSW_7_5_X.

bsunanda:Run2-alca17 Update the AlCaReco part for IsoTrack and Muon part

It involves the following packages:

Calibration/HcalAlCaRecoProducers

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Jul 15, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #10115 was updated. @cmsbuild, @mmusich, @diguida, @cerminar can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10115/193867/summary.html

There are some workflows for which there are errors in the baseline:
4.53 step 2
4.22 step 2
140.53 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@diguida
Copy link
Contributor

diguida commented Oct 20, 2015

please test

@diguida
Copy link
Contributor

diguida commented Oct 20, 2015

As reported by @bsunanda the 76X version has all the fixes: no crashes reported, events are selected.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9071/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@diguida
Copy link
Contributor

diguida commented Oct 23, 2015

+1
Back port of #10178
One small comment: it is missing only a change in a test cfg Calibration/HcalAlCaRecoProducers/test/AlCaHBHEMuonProducer_cfg.py

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 3, 2015
bsunanda:Run2-alca17 Update the AlCaReco part for IsoTrack and Muon part
@cmsbuild cmsbuild merged commit 1492188 into cms-sw:CMSSW_7_5_X Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants