-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MultiTrackValidator efficiency summary and efficiency vs. deltaR plots #10014
Fix MultiTrackValidator efficiency summary and efficiency vs. deltaR plots #10014
Conversation
…d those passing a pT cut
On the same go, fill bunchxSIM from all TrackingParticles (including out of time), and others from in-time TPs, but all without any futher selection.
I accidentally hit "submit" while still writing the description and running the final tests. All is fine now, so reopening. |
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X. Fix MultiTrackValidator efficiency summary and efficiency vs. deltaR plots It involves the following packages: CommonTools/RecoAlgos @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @monttj, @cmsbuild, @deguio, @slava77, @vadler, @danduggan can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Fix MultiTrackValidator efficiency summary and efficiency vs. deltaR plots
The recently (#9201) added efficiency summary plot (average efficiency for each input track collection) in MultiTrackValidator has a bug in putting also out-of-time TrackingParticles to the denominator. Also the computation of the DeltaR of minimum distance between any TP pair includes OOT TPs. This PR fixes both with the following developments (superseding #9956)
intimeOnly
flag to TrackingParticleSelector (with value False set to everywhere to not to change current behaviour)MTVHistoProducerAlgoForTracker::fill_recoAssociated_simTrack_histos()
already havesignalOnly=True
Tracking/Track/<iter>/simulation
which have also been filled from OOT TPs, and actually for those keeping more or less the current behaviour would be nice. Therefore,Tracking/Track/<iter>/simulation
are moved toTracking/Track/simulation
and filled only once per MTV instance (they are anyway the same for each iteration), and now from the set of all TPs without any selection (previously only those passing the TP selector in bullet 2 were used)bunchxSIM
is filled from both OOT and in-time TPs, while the others are filled only from IT TPsTested in 750pre6, expecting changes in
effic_vs_coll
,num_simul_coll
,num_assoc(simToReco)_coll
, andglobalEfficiencies
underTracking/Track
folder (num_*_coll
also in other MTV instances), andeffic_vs_dr
,num_simul_dr
, andnum_assoc(simToReco)_dr
in all MTV instances (in this case there is no change in the correspondingglobalEfficiencies
, as the integrals of numerator and denominator stay the same, only the DeltaR values change).In noPU samples the efficiency summary plots should change like (black=old, red=new)

and in pileup samples like

In pileup samples the number of TPs and efficiency vs. DeltaR should change like (no changes expected in noPU samples)


@rovere @VinInn