name 170, add const to vector size

cms-sw · Feb 20, 2023 · e43317c · e43317c
1 parent 84faa67
commit e43317c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/SimCalorimetry/HcalSimAlgos/src/HcalSiPM.cc b/SimCalorimetry/HcalSimAlgos/src/HcalSiPM.cc
@@ -81,6 +81,7 @@ const HcalSiPM::cdfpair& HcalSiPM::BorelCDF(unsigned int k) {
   // EPSILON determines the min and max # of xtalk cells that can be
   // simulated.
   constexpr double EPSILON = 1e-6;
+  constexpr uint32_t maxCDFsize = 170;  // safe max to avoid factorial to be infinite
   auto it = borelcdfs.find(k);
   if (it == borelcdfs.end()) {
     vector<double> cdf;
@@ -90,7 +91,7 @@ const HcalSiPM::cdfpair& HcalSiPM::BorelCDF(unsigned int k) {
     unsigned int i;
     double sumb = 0.;
     double iFact = 1.;
-    for (i = 0; i < 170; i++) {
+    for (i = 0; i < maxCDFsize; i++) {
       if (i > 0)
         iFact *= double(i);
       sumb += Borel(i, theCrossTalk, k, iFact);
@@ -102,7 +103,7 @@ const HcalSiPM::cdfpair& HcalSiPM::BorelCDF(unsigned int k) {
     unsigned int borelstartn = i;
 
     // calculate cdf[i]  limit to 170 to avoid iFact to become infinite
-    for (++i; i < 170; ++i) {
+    for (++i; i < maxCDFsize; ++i) {
       iFact *= double(i);
       sumb += Borel(i, theCrossTalk, k, iFact);
       cdf.push_back(sumb);

diff --git a/SimCalorimetry/HcalSimAlgos/src/HcalSiPMHitResponse.cc b/SimCalorimetry/HcalSimAlgos/src/HcalSiPMHitResponse.cc
@@ -209,7 +209,7 @@ CaloSamples HcalSiPMHitResponse::makeSiPMSignal(DetId const& id,
 
   LogDebug("HcalSiPMHitResponse") << "makeSiPMSignal for " << HcalDetId(id);
 
-  int nptb = photonTimeBins.size();
+  const int nptb = photonTimeBins.size();
   double sum[nptb];
   for (auto i = 0; i < nptb; ++i)
     sum[i] = 0;