Skip to content

Commit

Permalink
Merge pull request #43967 from iarspider-cmssw/glob2regex_fix
Browse files Browse the repository at this point in the history
Fix globToRegex and put it in anonymous namespace
  • Loading branch information
cmsbuild authored Feb 18, 2024
2 parents e2855ab + 3072d4e commit 3ff0606
Showing 1 changed file with 15 additions and 14 deletions.
29 changes: 15 additions & 14 deletions Validation/RecoTau/plugins/DQMHistNormalizer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -25,22 +25,23 @@

using namespace std;

// Three implementations were tested: char-by-char (this version),
// using std::string::find + std::string::replace and std::regex_replace.
// First one takes ~60 ns per iteration, second one ~85 ns,
// and the regex implementation takes nearly 1 us
std::string globToRegex(const std::string& s) {
std::string out;
out.reserve(s.size());
for (auto ch : s) {
if (ch == '*') {
out.push_back('.');
out.push_back('*');
namespace {
// Three implementations were tested: char-by-char (this version),
// using std::string::find + std::string::replace and std::regex_replace.
// First one takes ~60 ns per iteration, second one ~85 ns,
// and the regex implementation takes nearly 1 us
std::string globToRegex(const std::string& s) {
std::string out;
out.reserve(s.size());
for (auto ch : s) {
if (ch == '*') {
out.push_back('.');
}
out.push_back(ch);
}
out.push_back(ch);
return out;
}
return out;
}
} // namespace

class DQMHistNormalizer : public edm::one::EDAnalyzer<edm::one::SharedResources, edm::one::WatchRuns> {
public:
Expand Down

0 comments on commit 3ff0606

Please sign in to comment.