Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing code rules #112

Closed
wants to merge 3 commits into from
Closed

testing code rules #112

wants to merge 3 commits into from

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch scramv3.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 16, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmssw#46930

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba2db0/43466/summary.html
COMMIT: 1431031
CMSSW: CMSSW_15_0_X_2024-12-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/112/43466/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba2db0/43466/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba2db0/43466/git-merge-result

Build

I found compilation error when building:

    ClassesDefUtils.initROOT(args.library)
  File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_X_2024-12-15-2300/src/FWCore/Reflection/python/ClassesDefXmlUtils.py", line 101, in initROOT
    raise RuntimeError("failed to load library '"+library+"'")
RuntimeError: failed to load library 'libCalibrationEcalCalibAlgos.so'
Suggestion: You can run 'scram build updateclassversion' to generate src/Calibration/EcalCalibAlgos/src/classes_def.xml.generated with updated ClassVersion
gmake: *** [tmp/el8_amd64_gcc12/edm_checks/libCalibrationEcalCalibAlgos.so] Error 1
@@@@ ----> OK  EDM Class Transients 
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libFireworksTableWidget.so
>> Checking EDM Class Version for src/PhysicsTools/FWLite/src/classes_def.xml in libPhysicsToolsFWLite.so
>> Checking EDM Class Version for src/PhysicsTools/Heppy/src/classes_def.xml in libPhysicsToolsHeppy.so


@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmssw#46930

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmssw#46930

@cmsbuild
Copy link
Contributor

Pull request #112 was updated.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba2db0/43478/summary.html
COMMIT: c8fb6d7
CMSSW: CMSSW_15_0_X_2024-12-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/112/43478/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-scram-code-checks had ERRORS

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3510017
  • DQMHistoTests: Total failures: 476
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3509521
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmssw#46930

@cmsbuild
Copy link
Contributor

Pull request #112 was updated.

@smuzaffar smuzaffar closed this Dec 18, 2024
@smuzaffar smuzaffar deleted the smuzaffar-patch-2 branch December 18, 2024 09:22
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba2db0/43514/summary.html
COMMIT: 0586755
CMSSW: CMSSW_15_0_X_2024-12-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/112/43514/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3510017
  • DQMHistoTests: Total failures: 444
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3509553
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants