Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated root to tip of branch v6-32-00-patches #9460

Conversation

iarspider
Copy link
Contributor

ROOT changes

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_14_2_X/root632.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 14, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cfaa26/42152/summary.html
COMMIT: cb4aa37
CMSSW: CMSSW_14_2_ROOT632_X_2024-10-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9460/42152/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

@@@@ ----> OK  EDM Class Transients 
@@@@ ----> OK  EDM Class Transients 
@@@@ ----> OK  EDM Class Transients 
>> Checking EDM Class Version for src/CUDADataFormats/SiStripCluster/src/classes_def.xml in libCUDADataFormatsSiStripCluster.so
>> Skipped running EDM Class Version test
gmake: *** [tmp/el8_amd64_gcc12/edm_checks/libAnalysisDataFormatsTrackInfo.so] Error 1
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libCUDADataFormatsSiStripCluster.so
>> Checking EDM Class Version for src/CUDADataFormats/StdDictionaries/src/classes_def.xml in libCUDADataFormatsStdDictionaries.so
@@@@ ----> OK  EDM Class Transients 
@@@@ ----> OK  EDM Class Transients 


@smuzaffar
Copy link
Contributor

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cfaa26/42179/summary.html
COMMIT: cb4aa37
CMSSW: CMSSW_14_2_ROOT632_X_2024-10-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9460/42179/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cfaa26/42179/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cfaa26/42179/git-merge-result

Unit Tests

I found 3 errors in the following unit tests:

---> test TestFWCoreReflectionClassVersionUpdate had ERRORS
---> test TestIOPoolInputNoParentDictionary had ERRORS
---> test TestDQMOfflineConfigurationGotAll had ERRORS

Comparison Summary

Summary:

  • You potentially added 32 lines to the logs
  • Reco comparison results: 842 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331066
  • DQMHistoTests: Total failures: 7999
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3323047
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1967.3200000000006 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 67.823 KiB EcalPreshower/ByLumiSection
  • DQMHistoSizes: changed ( 4.22,... ): 0.150 KiB EcalPreshower/ESIntegrityTask
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

known unit tests failures when root version changes

---> test TestFWCoreReflectionClassVersionUpdate had ERRORS
---> test TestIOPoolInputNoParentDictionary had ERRORS

and TestDQMOfflineConfigurationGotAll is failing in IBs

@smuzaffar smuzaffar merged commit 61d0c50 into cms-sw:IB/CMSSW_14_2_X/root632 Oct 15, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants