Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.4.X] Update gosamcontrib version #9407

Merged

Conversation

Dominic-Stafford
Copy link
Contributor

Backport of #9406 for use in el8 and slc7 gridpack production. Updates gosam-contrib to version 2018.07.08 and hence ninja to v1.1. Tested that build works OK and external gridpacks can link against the new libraries

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dominic-Stafford for branch IB/CMSSW_12_4_X/master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 17, 2024

cms-bot internal usage

@smuzaffar smuzaffar changed the title Update gosamcontrib version [12.4.X] Update gosamcontrib version Sep 17, 2024
@cmsbuild
Copy link
Contributor

Pull request #9407 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67151c/41646/summary.html
COMMIT: e39a0db
CMSSW: CMSSW_12_4_X_2024-09-15-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9407/41646/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3766083
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3766059
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@cms-sw/orp-l2 , this is good to go in 12.4.X IB and next CMSW_12_4 release

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@Dominic-Stafford
Copy link
Contributor Author

Would it be possible for this request to merged and a new CMSSW_12_4 release to be made relatively soon, please? It would be nice to have this so we can start using these packages in gridpack generation

@antoniovilela
Copy link

+1

@cmsbuild cmsbuild merged commit 6dcddd5 into cms-sw:IB/CMSSW_12_4_X/master Oct 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants